Update Timor Leste holidays: fix 2025 Islamic holidays #2327

PPsyrius · 2025-03-05T07:56:43Z

Proposed change

Updates 2025 Islamic holidays assignment for Timor Leste.
Adds 2023-2025 test cases.
Add all missing Special National Holidays entries up to March 5th, 2025.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-03-05T07:56:51Z

Summary by CodeRabbit

New Features
- Enhanced Timor-Leste holiday calendar with updated 2025 holiday data—including Islamic holidays (Eid al-Adha on June 6 and Eid al-Fitr on March 31) and special national holidays (January 2, January 29, March 5).
- Updated the holiday descriptions for improved clarity, also incorporating adjustments for late 2024 holiday entries.

Walkthrough

The changes update Timor-Leste holiday data for 2025 by adding and modifying holiday entries. Updates occur in both the Python source file and the JSON snapshot, introducing new reference links and specific holiday dates—including Islamic and special national holidays. In addition, new test cases have been added to validate holiday data for 2023, 2024, and 2025.

Changes

File(s)	Change Summary
`holidays/.../timor_leste.py` `snapshots/.../TL_COMMON.json`	Python file: Added 2025 entries in `TimorLeste` (new reference link), `TimorLesteIslamicHolidays` (added Eid al-Adha on Jun 6 and Eid al-Fitr on Mar 31), and `TimorLesteStaticHolidays` (special national holidays on Jan 2, Jan 29, Mar 5). JSON file: Added new dates (2024-12-24, 2025-01-02, 2025-01-29), updated descriptions for 2025-03-05, 2025-03-31, and 2025-06-06, and removed 2025-03-30.
`tests/.../test_timor_leste.py`	Added new test methods (`test_2023_public`, `test_2024_public`, `test_2025_public`) to validate public holiday data for the respective years. Enhanced existing tests with additional dates and reference comments to reflect the updated holiday information.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f52858 and 276cdb6.

📒 Files selected for processing (3)

holidays/countries/timor_leste.py (4 hunks)
snapshots/countries/TL_COMMON.json (1 hunks)
tests/countries/test_timor_leste.py (12 hunks)

⏰ Context from checks skipped due to timeout of 300000ms (1)

GitHub Check: Test build on windows-latest

🔇 Additional comments (12)

tests/countries/test_timor_leste.py (4)

151-153: Changes to special government holidays look good.

The addition of new special national holidays for December 24, 2024, January 2, 2025, and January 29, 2025 correctly matches the updates in the source code.

455-480: Well-structured test case for 2023 public holidays.

Test includes the proper reference URL and comprehensive verification of all public holidays for 2023, including the Islamic holidays of Eid al-Fitr and Eid al-Adha with their correct dates.

482-507: Complete test coverage for 2024 public holidays.

The test properly verifies all 2024 public holidays with the correct reference link and includes the important Islamic holiday dates (April 10 for Eid al-Fitr and June 17 for Eid al-Adha).

509-534: Good implementation of 2025 public holidays test.

Test correctly verifies the updated Islamic holiday dates for 2025 (March 31 for Eid al-Fitr and June 6 for Eid al-Adha) along with all other public holidays. The reference link properly cites the official source.

holidays/countries/timor_leste.py (4)

39-39: Reference link for 2025 correctly added.

The new reference link properly documents the source for the 2025 holiday updates.

201-201: Eid al-Adha 2025 date properly updated.

The date for Eid al-Adha in 2025 is correctly set to June 6.

219-219: Eid al-Fitr 2025 date properly updated.

The date for Eid al-Fitr in 2025 is correctly set to March 31.

488-498: Special national holidays for 2025 properly added.

The three special national holidays for 2025 (January 2, January 29, and March 5) have been correctly added with appropriate reference links, maintaining consistency with the existing structure.

snapshots/countries/TL_COMMON.json (4)

515-515: December 24, 2024 special national holiday added.

The entry for December 24, 2024 as a National Holiday (Special) was correctly added to the JSON snapshot.

519-520: January 2025 special national holidays added.

Both January 2, 2025 and January 29, 2025 special national holidays have been properly added to the snapshot.

522-523: Ash Wednesday and Eid al-Fitr 2025 updates properly applied.

Two important updates made correctly:

March 5, 2025 now includes both Ash Wednesday and National Holidays (Special)

March 31, 2025 has the corrected Eid al-Fitr designation (removed "estimated" status)

530-530: Eid al-Adha 2025 update correctly applied.

The entry for June 6, 2025 has been properly updated to "Eid al-Adha" without the "estimated" designation.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-03-05T07:57:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-03-05T07:58:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3f52858) to head (276cdb6).
Report is 2 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2327   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          201       201           
  Lines        12374     12374           
  Branches      1775      1775           
=========================================
  Hits         12374     12374

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico

LGTM.

tests/countries/test_timor_leste.py

arkid15r

LGTM 👍

Update Timor Leste holidays: fix 2025 Islamic holidays

276cdb6

PPsyrius marked this pull request as ready for review March 5, 2025 07:56

PPsyrius requested review from arkid15r and KJhellico as code owners March 5, 2025 07:56

github-actions bot added snapshot test labels Mar 5, 2025

KJhellico approved these changes Mar 5, 2025

View reviewed changes

tests/countries/test_timor_leste.py Show resolved Hide resolved

arkid15r reviewed Mar 5, 2025

View reviewed changes

arkid15r enabled auto-merge March 5, 2025 19:38

arkid15r added this pull request to the merge queue Mar 5, 2025

Merged via the queue into vacanza:dev with commit 6bf52a6 Mar 5, 2025
33 checks passed

PPsyrius deleted the timor_lests_2025 branch March 6, 2025 01:55

This was referenced Mar 6, 2025

Update Philippines holidays: 2025 Eid'l Fitr and Eid'l Adha Tentative Date #2332

Merged

Update IslamicHolidays: add an option whether to add estimation label to holiday name #2298

Merged

KJhellico mentioned this pull request Mar 17, 2025

v0.69 #2355

Merged

This was referenced Mar 25, 2025

Update Philippines holidays: 2025 Eid'l Fitr #2367

Merged

Update Philippines holidays: adjust Bonifacio Day for 2023 #2370

Merged

coderabbitai bot mentioned this pull request Apr 3, 2025

Update Timor-Leste holidays: add en_TL, th l10n, update en_US l10n #2407

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update Timor Leste holidays: fix 2025 Islamic holidays #2327

Update Timor Leste holidays: fix 2025 Islamic holidays #2327

Uh oh!

PPsyrius commented Mar 5, 2025

Uh oh!

coderabbitai bot commented Mar 5, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Mar 5, 2025

Uh oh!

codecov bot commented Mar 5, 2025 •

edited

Loading

Uh oh!

KJhellico left a comment

Uh oh!

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Update Timor Leste holidays: fix 2025 Islamic holidays #2327

Update Timor Leste holidays: fix 2025 Islamic holidays #2327

Uh oh!

Conversation

PPsyrius commented Mar 5, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Mar 5, 2025

Quality Gate passed

Uh oh!

codecov bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading