Update Philippines holidays: 2025 Eid'l Fitr #2367

kleo · 2025-03-25T03:07:36Z

Proposed change

Update 2025 Date of Eid'l Fitr for the Philippines.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-03-25T03:07:47Z

Summary by CodeRabbit

Bug Fixes
- Corrected the 2025 Eid al-Fitr holiday date to April 1 for accurate observance.
Documentation
- Enhanced holiday details by adding an official reference to a significant proclamation.

Walkthrough

The changes update handling of the Eid al-Fitr holiday for 2025 in the Philippines module. In the main module, the import statement has been modified to remove March from the Gregorian calendar imports, the documentation now references Proclamation No. 839/2025, and the holiday date for Eid al-Fitr has been adjusted from March 31 to April 1. Corresponding test cases have been updated accordingly.

Changes

File(s)	Change Summary
`holidays/countries/philippines.py`	Removed `MAR` from the Gregorian calendar import; added `Proclamation No. 839/2025` in the documentation; updated Eid al-Fitr date for 2025 from Mar 31 to Apr 1.
`tests/countries/test_philippines.py`	Modified test cases to reflect the new Eid al-Fitr date for 2025, changing the expected date from 2025-03-31 to 2025-04-01.

Possibly related PRs

Update Philippines holidays: 2025 Eid'l Fitr and Eid'l Adha Tentative Date #2332: Involves updating the Eid al-Fitr date in the main Philippines holiday file, which parallels the change in this PR.
Update Timor Leste holidays: fix 2025 Islamic holidays #2327: Addresses updates to holiday dates in 2025, with a focus on Eid al-Fitr for Timor Leste, indicating a closely connected change.

Suggested labels

snapshot, test

Suggested reviewers

KJhellico
arkid15r

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5a9ed6 and 57f4e36.

📒 Files selected for processing (2)

holidays/countries/philippines.py (3 hunks)
tests/countries/test_philippines.py (2 hunks)

🔇 Additional comments (5)

tests/countries/test_philippines.py (2)

283-283: Approved: Date change for Eid'l Fitr 2025

The update correctly changes the date for Eid'l Fitr in 2025 from March 31 to April 1, aligning with the official proclamation.

463-463: Approved: Consistent date update in test_2025

The Eid'l Fitr date has been consistently updated in this comprehensive test case for 2025 holidays.

holidays/countries/philippines.py (3)

16-16: Good import cleanup

Removing the unused MAR import is appropriate since it's no longer needed after the date change.

54-54: Well-documented reference

Adding the reference to Proclamation No. 839/2025 provides excellent traceability for the date change.

262-262: Approved: Core date change for Eid al-Fitr 2025

The implementation correctly updates the date from March 31 to April 1, fulfilling the PR objective.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-03-25T03:08:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PPsyrius

LGTM 🇵🇭

codecov · 2025-03-25T03:24:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e5a9ed6) to head (57f4e36).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2367   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          204       204           
  Lines        12853     12853           
  Branches      1817      1817           
=========================================
  Hits         12853     12853

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkid15r

LGTM

arkid15r · 2025-03-25T03:47:01Z

@kleo thanks for keeping this accurate!

kleo · 2025-03-25T07:49:58Z

You're welcome! Thanks for the awesome project!

Update Philippines holidays: 2025 Eid'l Fitr

57f4e36

kleo requested review from arkid15r, KJhellico and PPsyrius as code owners March 25, 2025 03:07

github-actions bot added the test label Mar 25, 2025

PPsyrius approved these changes Mar 25, 2025

View reviewed changes

arkid15r reviewed Mar 25, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Mar 25, 2025

Merged via the queue into vacanza:dev with commit 523d27c Mar 25, 2025
33 checks passed

coderabbitai bot mentioned this pull request Mar 25, 2025

Update Philippines holidays: adjust Bonifacio Day for 2023 #2370

Merged

9 tasks

arkid15r mentioned this pull request Apr 7, 2025

v0.70 #2443

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update Philippines holidays: 2025 Eid'l Fitr #2367

Update Philippines holidays: 2025 Eid'l Fitr #2367

Uh oh!

kleo commented Mar 25, 2025

Uh oh!

coderabbitai bot commented Mar 25, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Mar 25, 2025

Uh oh!

PPsyrius left a comment

Uh oh!

codecov bot commented Mar 25, 2025 •

edited

Loading

Uh oh!

arkid15r left a comment

Uh oh!

Uh oh!

arkid15r commented Mar 25, 2025

Uh oh!

kleo commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

Update Philippines holidays: 2025 Eid'l Fitr #2367

Update Philippines holidays: 2025 Eid'l Fitr #2367

Uh oh!

Conversation

kleo commented Mar 25, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud bot commented Mar 25, 2025

Quality Gate passed

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arkid15r commented Mar 25, 2025

Uh oh!

kleo commented Mar 25, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Mar 25, 2025 •

edited

Loading

codecov bot commented Mar 25, 2025 •

edited

Loading