-
-
Notifications
You must be signed in to change notification settings - Fork 543
Update Timor-Leste holidays: add en_TL
, th
l10n, update en_US
l10n
#2407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughThis pull request updates the supported languages for Timor Leste by adding the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (8)
🧰 Additional context used🧠 Learnings (5)holidays/locale/tet/LC_MESSAGES/TL.po (1)
holidays/locale/pt_TL/LC_MESSAGES/TL.po (1)
holidays/locale/th/LC_MESSAGES/TL.po (1)
holidays/locale/en_TL/LC_MESSAGES/TL.po (2)
snapshots/countries/TL_COMMON.json (1)
🧬 Code Definitions (1)tests/countries/test_timor_leste.py (3)
⏰ Context from checks skipped due to timeout of 300000ms (1)
🔇 Additional comments (31)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2407 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 208 208
Lines 13244 13244
Branches 1899 1899
=========================================
Hits 13244 13244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (9)
README.md
(1 hunks)holidays/countries/timor_leste.py
(4 hunks)holidays/locale/en_TL/LC_MESSAGES/TL.po
(1 hunks)holidays/locale/en_US/LC_MESSAGES/TL.po
(3 hunks)holidays/locale/pt_TL/LC_MESSAGES/TL.po
(4 hunks)holidays/locale/tet/LC_MESSAGES/TL.po
(4 hunks)holidays/locale/th/LC_MESSAGES/TL.po
(1 hunks)snapshots/countries/TL_COMMON.json
(75 hunks)tests/countries/test_timor_leste.py
(5 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
tests/countries/test_timor_leste.py (3)
holidays/countries/timor_leste.py (1)
TimorLeste
(27-182)tests/countries/test_indonesia.py (1)
test_l10n_th
(600-623)tests/countries/test_brunei.py (1)
test_l10n_th
(217-238)
🔇 Additional comments (17)
README.md (1)
1155-1155
: Addition of new supported languages for Timor LesteThe update adds
en_TL
andth
to the list of supported languages for Timor Leste, aligning with the PR objectives to enhance localization support.holidays/locale/th/LC_MESSAGES/TL.po (1)
1-165
: New Thai localization file for Timor Leste holidaysThis new localization file adds proper Thai translations for all Timor Leste holidays, enhancing the library's internationalization capabilities. The translations appear accurate and follow the proper structure for PO files.
holidays/locale/tet/LC_MESSAGES/TL.po (2)
17-17
: Updated metadata informationProject version, revision date, and generator version have been properly updated, along with translator information.
Also applies to: 19-20, 27-27
42-42
: Standardized holiday name commentsThe comments have been updated to use "International" instead of "World" for labor, children's, and human rights days, providing consistent terminology across localization files.
Also applies to: 110-110, 119-119
holidays/locale/en_TL/LC_MESSAGES/TL.po (1)
1-165
: New English (Timor Leste) localization fileThis new localization file provides English translations specific to Timor Leste, enhancing the regional language support as intended in the PR objectives.
holidays/locale/pt_TL/LC_MESSAGES/TL.po (2)
17-17
: Metadata updates look good.Updated version number, revision date, translator information, and generator version successfully reflect this contribution.
Also applies to: 19-20, 27-27
42-42
: Consistent terminology update from "World" to "International".The update from "World" to "International" for these holiday comments is consistent with changes in other localization files and aligns with standard terminology.
Also applies to: 110-110, 119-119
holidays/countries/timor_leste.py (2)
51-51
: Language support expansion looks good.Successfully added "en_TL" and "th" to the supported languages attribute while preserving existing languages. The sequence also matches the documentation updates.
83-83
: Consistent terminology change from "World" to "International".The comment updates properly align with the terminology changes in the localization files and maintain consistency across the codebase.
Also applies to: 153-153, 170-170
tests/countries/test_timor_leste.py (4)
30-30
: Code simplification in test_no_holidays is good.Consolidated multiple assertions into a single assertion that simultaneously tests for both GOVERNMENT and WORKDAY categories, making the code more concise.
608-648
: Well-implemented test for en_TL localization.The new test method thoroughly validates the English for Timor-Leste localization with comprehensive holiday coverage. This supports the PR's objective of adding en_TL support.
664-664
: Consistent terminology updates in test assertions.The holiday name updates from "World" to "International" in the en_US test assertions align with the changes made to the localization files.
Also applies to: 669-669, 686-686
731-768
: Well-implemented test for Thai localization.The new test method provides thorough validation of Thai holiday names, following similar patterns seen in tests for other languages like Indonesian and Brunei. This supports the PR's objective to add Thai language support.
holidays/locale/en_US/LC_MESSAGES/TL.po (2)
17-17
: Metadata updates look good.Updated version number, revision date, translator information, and generator version successfully reflect this contribution.
Also applies to: 19-20, 27-27
42-44
: Consistent terminology and translation updates.The changes from "World" to "International" for holiday names are well-implemented and consistently applied across all relevant holiday entries.
Also applies to: 110-112, 119-121
snapshots/countries/TL_COMMON.json (2)
10-10
: Uniform Renaming for Children’s Day
The holiday formerly labeled as “World Children's Day” has been updated uniformly to “International Children's Day” (e.g. at 2006-06-01 on line 10 and 2007-06-01 on line 32, with similar changes later). This change appears consistent across the dataset and supports the new localization standards.Also applies to: 32-32, 74-74
22-22
: Standardizing Human Rights Day Naming
The holiday now reads “International Human Rights Day” (as seen at 2006-12-10 on line 22, 2007-12-10 on line 44, and 2008-12-10 on line 65), replacing any previous “World Human Rights Day” variations. This consistent update supports clarity in the holiday naming conventions.Also applies to: 44-44, 65-65
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Proposed change
Updates Timor-Leste
en_US
l10n as per discussed in #2394 with @KJhellico , as well as adding source-accurateen_TL
andth
l10n.Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green