+
Skip to content

Update Philippines holidays: 2025 Eid'l Fitr and Eid'l Adha Tentative Date #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2025
Merged

Update Philippines holidays: 2025 Eid'l Fitr and Eid'l Adha Tentative Date #2332

merged 3 commits into from
Mar 8, 2025

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Mar 6, 2025 •
edited
Loading

Proposed change

  • Adds 2025 Tentative Date of Eid'l Fitr and Eid'l Adha for the Philippines.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2025 •
edited
Loading

Summary by CodeRabbit

  • New Features

    • Updated the holiday schedule for 2025 with confirmed dates for major holidays, including the Lunar New Year and Eid celebrations.

  • Bug Fixes

    • Corrected and standardized holiday dates to remove estimation labels and ensure consistency across the application.

  • Tests

    • Enhanced test cases to verify the accuracy of the new 2025 holiday dates.

Walkthrough

This pull request updates the holiday calendar for the Philippines by modifying the holidays/countries/philippines.py file, adjusting the JSON snapshot for holiday dates, and enhancing the associated tests. Key changes include the addition of confirmed dates for Eid al-Fitr and Eid al-Adha in 2025, as well as the inclusion of the Chinese New Year date. These updates ensure accuracy in holiday observance for the upcoming year.

Changes

File(s) Change Summary
holidays/countries/philippines.py Updated import statement to include MAR; added tentative 2025 dates for Eid al-Fitr (MAR 31) and Eid al-Adha (JUN 6) in PhilippinesIslamicHolidays; added 2025 Chinese New Year date (JAN 29) in PhilippinesChineseHolidays.
snapshots/countries/PH_COMMON.json Updated holiday dates for 2025: changed Eid al-Fitr from "2025-03-30 (estimated)" to "2025-03-31" (confirmed) and clarified Eid al-Adha as exact on "2025-06-06".
tests/countries/test_philippines.py Added Chinese New Year date for 2025 (2025-01-29); updated Eid al-Fitr test date to "2025-03-31" and confirmed Eid al-Adha test date as "2025-06-06".

Possibly related PRs

Suggested reviewers

  • KJhellico
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6cbb967 and c374546.

📒 Files selected for processing (1)
  • holidays/countries/philippines.py (5 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (2)
  • GitHub Check: Test build on windows-latest
  • GitHub Check: Test build on ubuntu-latest
🔇 Additional comments (6)
holidays/countries/philippines.py (6)

16-16: Import addition looks good

The addition of MAR to the import statement is necessary to support the new 2025 Eid al-Fitr date.

53-53: Nice job adding the reference link

Good addition of the reference for the 2025 Eid'l Fitr and Eid'l Adha tentative dates, which provides proper documentation for the date sources.

207-207: Chinese New Year date addition looks good

The 2025 Lunar New Year date (January 29) has been added correctly to maintain the holiday calendar's accuracy.

228-228: Eid al-Adha date looks good

The tentative 2025 Eid al-Adha date (June 6) has been added based on the reference provided. This aligns with the previous discussions about having verified dates.

255-255: Eid al-Fitr date looks correct

The tentative 2025 Eid al-Fitr date (March 31) has been added correctly. This matches the Philippines-based tentative date rather than the default Islamic calendar implementation, which is appropriate.

192-208: Consider the removal of PhilippinesChineseHolidays class

The PR summary mentioned removing PhilippinesChineseHolidays as its implementation is fully aligned with _ChineseLunisolar holidays, but I don't see this implementation in the current changes.

Would you like to provide more information about the intended removal of this class? If this is still part of the plan, we should check how it would affect the rest of the codebase.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e2f0790) to head (c374546).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2332   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          203       203           
  Lines        12402     12402           
  Branches      1777      1777           
=========================================
  Hits         12402     12402

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico
KJhellico reviewed Mar 6, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.3% Duplication on New Code

See analysis details on SonarQube Cloud

@PPsyrius PPsyrius requested a review from KJhellico March 7, 2025 02:45
@PPsyrius PPsyrius mentioned this pull request Mar 7, 2025
Open
KJhellico
KJhellico approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

arkid15r
arkid15r approved these changes Mar 8, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇵🇭 LGTM

@arkid15r arkid15r added this pull request to the merge queue Mar 8, 2025
Merged via the queue into vacanza:dev with commit d062b95 Mar 8, 2025
33 checks passed
@PPsyrius PPsyrius deleted the ph_2025 branch March 8, 2025 04:10
@coderabbitai coderabbitai bot mentioned this pull request Mar 8, 2025
Merged
9 tasks
@KJhellico KJhellico mentioned this pull request Mar 17, 2025
Merged
This was referenced Mar 25, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico KJhellico approved these changes

Assignees
No one assigned
Labels
snapshot test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PPsyrius @arkid15r @KJhellico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载