This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(playground): embbed codemirror-lang-rome-ast #2977
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaReiser , I think this is what you want. |
|
I build successfully locally, I have no idea what's going on with CI. |
…pression (rome#2973) * fix: 🐛 function expression should push new scope * fix: 🐛 semantic scope * fix: 🐛 remove mainn * fix: 🐛 pop scope when leave function expr * style: 💄 fmt * chore: 🤖 revert * chore: 🤖 rever t * test: 💍 more read test case
ematipico
suggested changes
Aug 2, 2022
| "@codemirror/state": "6.1.0", | ||
| "@codemirror/view": "6.1.0", | ||
| "@uiw/react-codemirror": "^4.11.4", | ||
| "codemirror-lang-rome-ast": "file:./lang-rome-ast", |
There was a problem hiding this comment.
pnpm has support for workspaces, which we should use for this particular case: https://pnpm.io/pnpm-workspace_yaml
There was a problem hiding this comment.
I will check this out when I have time, converting it to draft now.
| "@codemirror/view": "6.0.0", | ||
| "@lezer/generator": "^1.0.0", | ||
| "codemirror": "^6.0.0", | ||
| "rome": "0.7.0-next.f6510d6" |
There was a problem hiding this comment.
Suggested change
| "rome": "0.7.0-next.f6510d6" | |
| "rome": "next" |
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/IWANABETHATGUY/lang-rome-ast" |
There was a problem hiding this comment.
I presume this is a leftover of your repo?
Comment on lines
+1
to
+2
| node_modules | ||
| dist |
There was a problem hiding this comment.
So we know they are folders
Suggested change
| node_modules | |
| dist | |
| node_modules/ | |
| dist/ |
…atch mutations (rome#2980) * fix(rome_js_analyze): fix the removal of nodes from syntax lists in batch mutations * address PR review * run the configuration codegen
…rome#2954) Co-authored-by: Micha Reiser <micha@reiser.io>
…ements` (rome#2981) * fix(rome_js_analyze): improve the handling of trivia in `useBlockStatements` * run lintdoc
Co-authored-by: Micha Reiser <micha@rome.tools>
…FormatFunction` (rome#2988)
* feat: 🎸 no-import-assign * style: 💄 fmt * fix: 🐛 cr issues * docs: ✏️ update doc * chore: 🤖 avoid unncessary cast * chore: 🤖 lintdoc * fix: 🐛 use ctx model api * fix: 🐛 lint doc * fix: 🐛 cr issue * fix: 🐛 cr issue * chore: 🤖 update log * chore: 🤖 codegen configuration
* no unused variables lint rule
…NABETHATGUY/tools into chore/embbed-codemirror-lang
|
This pull request is too messy, I would open it again once I found a solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2984
Test Plan