This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): Loop formatting #2970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afcf2c3 to
e307116
Compare
Deploying with
|
| Latest commit: |
62b84d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af4ec45b.tools-8rn.pages.dev |
| Branch Preview URL: | https://feat-format-loops.tools-8rn.pages.dev |
2c99e43 to
cfb8680
Compare
ematipico
approved these changes
Aug 2, 2022
|
Could you add the metrics please? |
File Based Average Prettier Similarity: 77.98% -> 77.97% My understanding of this small regression is that it is mainly coming from how we format comments. I wouldn't give this too much weight for now as we are aware that this is an open issue and requires more fundamental architecture changes |
cfb8680 to
549a2fd
Compare
549a2fd to
62b84d5
Compare
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-visits the formatting of loops. I verified that Rome generates the same IR (except for comments).
I tried to match the same formatting for the semicolon's leading comments of
continueandbreakstatements but wasn't able to match the behaviour withouta) adding a serious amount of complexity
b) get a stable format.
That's why I left the "default" comments formatting in place.
Test Plan
Verified the updated snapshots.