+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(playground): rome ast codemirror grammar #2974

Merged
merged 1 commit into from
Jul 30, 2022
Merged

fix(playground): rome ast codemirror grammar #2974

merged 1 commit into from
Jul 30, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

Summary

  1. Fixing wrong Rome ast codemirror grammar
  2. Screenshot:
    Main
    image
    Current Branch
    image
  3. For more details, you could see patch pr IWANABETHATGUY/lang-rome-ast@8134a49

Test Plan

  1. Running the playground locally or see my screenshot.

@IWANABETHATGUY IWANABETHATGUY requested a review from a team July 30, 2022 10:44
MichaReiser
MichaReiser approved these changes Jul 30, 2022
View reviewed changes
Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
How hard would it be to add a grammar for Rome's formatter IR? Would be awesome to have collapsing of elements.

have you had any time looking into why the grammar doesn't work when embedding it locally?

@MichaReiser MichaReiser changed the title fix: 🐛 rome ast codemirror grammar fix(playground): rome ast codemirror grammar Jul 30, 2022
@MichaReiser MichaReiser merged commit 0759000 into rome:main Jul 30, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the fix/playground-rome-ast branch July 30, 2022 14:43
This was referenced Jul 31, 2022
Closed
Closed
IWANABETHATGUY added a commit to IWANABETHATGUY/tools that referenced this pull request Aug 22, 2022
@IWANABETHATGUY
fix(playground): rome ast codemirror grammar (rome#2974)
53caaf0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @MichaReiser
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载