This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): improve the handling of trivia in useBlockStatements
#2981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
approved these changes
Aug 2, 2022
crates/rome_js_analyze/src/analyzers/js/use_block_statements.rs
Outdated
Show resolved
Hide resolved
0397a9d to
eb9aed0
Compare
Deploying with
|
| Latest commit: |
3046015
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3d25172d.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-use-block-statements.tools-8rn.pages.dev |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
…ements` (rome#2981) * fix(rome_js_analyze): improve the handling of trivia in `useBlockStatements` * run lintdoc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #2943 by introducing additional logic in the code generating the auto-fix for the rule to inspect the tokens and nodes being modified, and move or add trivia pieces accordingly.
I also fixed the query used by the rule to ensure it would trigger separately for if statements and else clauses, ensuring both the consequent and alternate statements would have a diagnostic and code action emitted, and not only the first one visited by the rule.
Test Plan
I added a number of additional test cases in the snapshot tests for the rule to verify the handling of empty statements in if-else chains and indentation