Initial i18n for Fulfillment #6545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
|
This was referenced Oct 18, 2022
Closed
brent-hoover
requested changes
Oct 31, 2022
packages/api-plugin-fulfillment-method-pickup-store/src/i18n/en.json
Outdated
Show resolved
Hide resolved
| @@ -245,7 +245,7 @@ importers: | |||
| '@reactioncommerce/logger': link:../../packages/logger | |||
| '@reactioncommerce/nodemailer': 5.0.5 | |||
| '@reactioncommerce/random': link:../../packages/random | |||
| '@snyk/protect': 1.1017.0 | |||
There was a problem hiding this comment.
Probably best to just remove this
Merged
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
This was referenced Nov 3, 2022
aldeed
approved these changes
Dec 8, 2022
vanpho93
approved these changes
Dec 9, 2022
|
This PR is replaced by the commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sujith mail.sujithvn@gmail.com
Resolves #6473
Impact: minor
Type: feature
Issue
There are no localised versions of customer or admin facing messages.
Solution
Created i18n config files for the newly introduced plugins.
The required files for two of the below mentioned plugins were completely copied over from old plugin.
api-plugin-fulfillment-type-shipping(copied over fromapi-plugin-shipments)api-plugin-fulfillment-method-shipping-flat-rate(copied over fromapi-plugin-shipments-flat-rate)Added new config files for remaining 4 plugins below
api-plugin-fulfillmentapi-plugin-fulfillment-type-pickupapi-plugin-fulfillment-method-pickup-storeapi-plugin-fulfillment-method-shipping-upsBreaking changes
None
Testing
Need to co-ordinate with the Front-end team to understand if there are any additional entries required in the config-files for the new plugins.