-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New fulfillment type pickup #6613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
|
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
...api-plugin-fulfillment-method-pickup-store/src/getFulfillmentMethodsWithQuotesPickupStore.js
Outdated
Show resolved
Hide resolved
...api-plugin-fulfillment-method-pickup-store/src/getFulfillmentMethodsWithQuotesPickupStore.js
Outdated
Show resolved
Hide resolved
...api-plugin-fulfillment-method-pickup-store/src/getFulfillmentMethodsWithQuotesPickupStore.js
Outdated
Show resolved
Hide resolved
packages/api-plugin-fulfillment-method-pickup-store/src/util/validateOrderMethodsstore.js
Outdated
Show resolved
Hide resolved
packages/api-plugin-fulfillment-method-pickup-store/src/startup.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
...es/api-plugin-fulfillment-method-pickup-store/src/fulfillmentMethodsWithQuotesPickupStore.js
Show resolved
Hide resolved
packages/api-plugin-fulfillment-type-pickup/src/checkAndCreateFulfillmentType.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One pattern suggestion but otherwise LGTM
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
Signed-off-by: Sujith mail.sujithvn@gmail.com
This PR replaces #6577
Resolves #6471
Impact: breaking
Type: feature
Issue
In the current system, the only way for order fulfillment is via shipping which is hardcoded into the system. We need to introduce the flexibility for users to add their own fulfillment types via plugins.
Solution
We are creating a base fulfillment plugin which would enable other fulfillment types (like shipping, pickup, digital) to be introduced via plugins. Each of the newly introduced fulfillment type plugin would need to have the specific fulfillment methods also to be added as separate plugins. Example, fulfillment type 'pickup' could have fulfillment methods like 'store pickup' and 'curb-side pickup'.
This PR is 3rd entry for new-fulfillment-type-pickup
PR Details in order
Existing PRs based on the #6480 (to be updated to point to #6610)
We shall change the base branch of the 3 existing PRs (i18n #6545, dataMigration #6633 , setDefaultFFtype #6543) to point to 00 fulfillment base
API-PLUGIN-FULFILLMENT-TYPE-PICKUP
API-PLUGIN-FULFILLMENT-METHOD-PICKUP-STORE
Breaking changes
Since this is the new way of handling fulfillment, the existing shipment plugins would not work along with this. User would need to migrate the data (migration script will be developed) and remove the shipment plugins (api-plugin-shipments and api-plugin-shipments-flat-rate).
Testing
All this is new code and at this stage this is not integrated to reaction, meaning the plugins.json is not updated to include this plugin. Hence proper testing can be carried out only after merging in the remaining PRs.