meson: do a link test for locale_charset()
#1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't just check for `locale_charset` as some (very silly) distributions ship, or allow end users to install, GNU libiconv on GNU libc systems. - Move `HAVE_CODESET` and `HAVE_LIBCHARSET` checks into `iconv` dep conditional - perform link test against libcharset to see if it is usable - add a visible warning that GNU libiconv should not be installed on a GNU libc system, if libcharset (libiconv) linking fails due to apparent conflicts with glibc iconv. See Also: fvwmorg#1186 Signed-off-by: Matt Jolly <kangie@gentoo.org>
|
Still a little concerned about whether it should be possible to use Lines 270 to 272 in 6dbc601 musl, for example, "has" |
|
Well, having checked this on Alpine (which I use on my Thinkpad), this check as you've got it doesn't break anything. However, the behaviour of I'm guessing other must variants (Gentoo, Void) would also favour that? |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jun 7, 2025
# changes ### Enhancements * FvwmRearrange: Use -on_screen to tile/cascade all windows on the monitor. by @pghvlaans in fvwmorg/fvwm3#1170 * FvwmRearrange: Add -win_cmd COMMAND option. by @somiaj in fvwmorg/fvwm3#1179 * expand.c: Add "maximum" and "minimum" to math. by @pghvlaans in fvwmorg/fvwm3#1176 ### Other Changes * build: macos: fix path to fribidi by @ThomasAdam in fvwmorg/fvwm3#1174 * fvwm-convert-2.6: fix syntax error by @ThomasAdam in fvwmorg/fvwm3#1177 * style: remove superfluous debug by @ThomasAdam in fvwmorg/fvwm3#1181 * Remove autotools & modernise build CI/CD by @ThomasAdam in fvwmorg/fvwm3#1191 * build: remove go-1.14.0 check by @ThomasAdam in fvwmorg/fvwm3#1195 * Fix crash in FvwmPager and clarify Balloons option. by @somiaj in fvwmorg/fvwm3#1197 * build: modify release version script by @ThomasAdam in fvwmorg/fvwm3#1201 * meson: do a link test for `locale_charset()` by @Kangie in fvwmorg/fvwm3#1203 * Small RandR fixes by @ThomasAdam in fvwmorg/fvwm3#1207 * setup_visible_names: don't ignore when both set by @ThomasAdam in fvwmorg/fvwm3#1208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't just check for
locale_charsetas some (very silly) distributions ship, or allow end users to install, GNU libiconv on GNU libc systems.HAVE_CODESETandHAVE_LIBCHARSETchecks intoiconvdep conditionalSee Also: #1186