+
Skip to content

Fix crash in FvwmPager and clarify Balloons option. #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

somiaj
Copy link
Collaborator

@somiaj somiaj commented May 19, 2025

This fixes the issues mentioned in #1189 without the need to do any refactoring of the code.

  • When WindowFont None is set after the font had been defined, ensure it is set back to NULL to prevent FvwmPager from crashing.
  • Clarify the Balloon type option in the FvwmPager manual page and how it is used to determine if and when to show balloon windows.

FvwmPager would crash if `WindowFont` was set then later
set to `None`. This makes sure that if `WindowFont None`
is used, the font is set back to Null for fallback checks.

This also clarifies the `Balloon type` option. This option
no longer accepts NULL inputs, use All as an example to
show balloon windows everywhere, and state default is None.
@ThomasAdam ThomasAdam added the relates:module Issue is in module code label May 19, 2025
@ThomasAdam ThomasAdam added this to FVWM3 May 19, 2025
@github-project-automation github-project-automation bot moved this to PRs in FVWM3 May 19, 2025
@ThomasAdam ThomasAdam added the type:bug Something's broken! label May 19, 2025
@ThomasAdam ThomasAdam added this to the 1.1.3 milestone May 19, 2025
@ThomasAdam ThomasAdam merged commit 6370adf into main May 19, 2025
8 checks passed
@ThomasAdam ThomasAdam deleted the js/pager-fix-1189 branch May 19, 2025 16:28
@github-project-automation github-project-automation bot moved this from PRs to Done in FVWM3 May 19, 2025
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 7, 2025
# changes

### Enhancements
* FvwmRearrange: Use -on_screen to tile/cascade all windows on the monitor. by @pghvlaans in fvwmorg/fvwm3#1170
* FvwmRearrange: Add -win_cmd COMMAND option. by @somiaj in fvwmorg/fvwm3#1179
* expand.c: Add "maximum" and "minimum" to math. by @pghvlaans in fvwmorg/fvwm3#1176

### Other Changes
* build: macos: fix path to fribidi by @ThomasAdam in fvwmorg/fvwm3#1174
* fvwm-convert-2.6: fix syntax error by @ThomasAdam in fvwmorg/fvwm3#1177
* style: remove superfluous debug by @ThomasAdam in fvwmorg/fvwm3#1181
* Remove autotools & modernise build CI/CD by @ThomasAdam in fvwmorg/fvwm3#1191
* build: remove go-1.14.0 check by @ThomasAdam in fvwmorg/fvwm3#1195
* Fix crash in FvwmPager and clarify Balloons option. by @somiaj in fvwmorg/fvwm3#1197
* build: modify release version script by @ThomasAdam in fvwmorg/fvwm3#1201
* meson: do a link test for `locale_charset()` by @Kangie in fvwmorg/fvwm3#1203
* Small RandR fixes by @ThomasAdam in fvwmorg/fvwm3#1207
* setup_visible_names: don't ignore when both set by @ThomasAdam in fvwmorg/fvwm3#1208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates:module Issue is in module code type:bug Something's broken!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载