Fix crash in FvwmPager and clarify Balloons option. #1197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FvwmPager would crash if `WindowFont` was set then later set to `None`. This makes sure that if `WindowFont None` is used, the font is set back to Null for fallback checks. This also clarifies the `Balloon type` option. This option no longer accepts NULL inputs, use All as an example to show balloon windows everywhere, and state default is None.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jun 7, 2025
# changes ### Enhancements * FvwmRearrange: Use -on_screen to tile/cascade all windows on the monitor. by @pghvlaans in fvwmorg/fvwm3#1170 * FvwmRearrange: Add -win_cmd COMMAND option. by @somiaj in fvwmorg/fvwm3#1179 * expand.c: Add "maximum" and "minimum" to math. by @pghvlaans in fvwmorg/fvwm3#1176 ### Other Changes * build: macos: fix path to fribidi by @ThomasAdam in fvwmorg/fvwm3#1174 * fvwm-convert-2.6: fix syntax error by @ThomasAdam in fvwmorg/fvwm3#1177 * style: remove superfluous debug by @ThomasAdam in fvwmorg/fvwm3#1181 * Remove autotools & modernise build CI/CD by @ThomasAdam in fvwmorg/fvwm3#1191 * build: remove go-1.14.0 check by @ThomasAdam in fvwmorg/fvwm3#1195 * Fix crash in FvwmPager and clarify Balloons option. by @somiaj in fvwmorg/fvwm3#1197 * build: modify release version script by @ThomasAdam in fvwmorg/fvwm3#1201 * meson: do a link test for `locale_charset()` by @Kangie in fvwmorg/fvwm3#1203 * Small RandR fixes by @ThomasAdam in fvwmorg/fvwm3#1207 * setup_visible_names: don't ignore when both set by @ThomasAdam in fvwmorg/fvwm3#1208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues mentioned in #1189 without the need to do any refactoring of the code.
WindowFont Noneis set after the font had been defined, ensure it is set back toNULLto prevent FvwmPager from crashing.Balloon typeoption in the FvwmPager manual page and how it is used to determine if and when to show balloon windows.