+
Skip to content

FvwmRearrange: Use -on_screen to tile/cascade all windows on the monitor. #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

pghvlaans
Copy link
Contributor

@pghvlaans pghvlaans commented Feb 13, 2025

This PR adds a new option, -on_screen, to FvwmRearrange. It causes all windows on the monitor to be tiled or cascaded in the bounding box, even if they do not intersect it. Since it is already possible to do this on a per-desk basis with -desk, I thought it would be nice to have something similar for pages the current monitor.

somiaj
somiaj previously requested changes Feb 13, 2025
@pghvlaans pghvlaans changed the title FvwmRearrange: Use -page to tile/cascade all windows on the monitor. FvwmRearrange: Use -monitor to tile/cascade all windows on the monitor. Feb 14, 2025
@pghvlaans
Copy link
Contributor Author

Should I squash the two commits?

@ThomasAdam
Copy link
Member

Should I squash the two commits?

Yes please.

@somiaj somiaj dismissed their stale review February 14, 2025 09:42

Thanks for the updates.

@somiaj
Copy link
Collaborator

somiaj commented Feb 14, 2025

I can't think of a better name than -monitor, but now -screen and -monitor might be confusing. Anyways I'll let @ThomasAdam take things from here.

@pghvlaans
Copy link
Contributor Author

Maybe -from_whole_screen or -all_on_screen would be clearer.

@somiaj
Copy link
Collaborator

somiaj commented Feb 14, 2025

I like -all_on_screen, could probably just shorten it to -on_screen, making it sound more like a toggle.

@ThomasAdam
Copy link
Member

I like -all_on_screen, could probably just shorten it to -on_screen, making it sound more like a toggle.

Agreed. -on_screen works for me!

@pghvlaans pghvlaans changed the title FvwmRearrange: Use -monitor to tile/cascade all windows on the monitor. FvwmRearrange: Use -on_screen to tile/cascade all windows on the monitor. Feb 14, 2025
@pghvlaans
Copy link
Contributor Author

Same here; pushed. Thanks!

@ThomasAdam ThomasAdam added type:enhancement Augmenting an existing feature relates:module Issue is in module code labels Feb 14, 2025
@ThomasAdam ThomasAdam added this to the 1.1.3 milestone Feb 14, 2025
@ThomasAdam ThomasAdam merged commit 7b901c0 into fvwmorg:main Feb 14, 2025
12 checks passed
@pghvlaans pghvlaans deleted the page-tile branch February 20, 2025 18:02
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 7, 2025
# changes

### Enhancements
* FvwmRearrange: Use -on_screen to tile/cascade all windows on the monitor. by @pghvlaans in fvwmorg/fvwm3#1170
* FvwmRearrange: Add -win_cmd COMMAND option. by @somiaj in fvwmorg/fvwm3#1179
* expand.c: Add "maximum" and "minimum" to math. by @pghvlaans in fvwmorg/fvwm3#1176

### Other Changes
* build: macos: fix path to fribidi by @ThomasAdam in fvwmorg/fvwm3#1174
* fvwm-convert-2.6: fix syntax error by @ThomasAdam in fvwmorg/fvwm3#1177
* style: remove superfluous debug by @ThomasAdam in fvwmorg/fvwm3#1181
* Remove autotools & modernise build CI/CD by @ThomasAdam in fvwmorg/fvwm3#1191
* build: remove go-1.14.0 check by @ThomasAdam in fvwmorg/fvwm3#1195
* Fix crash in FvwmPager and clarify Balloons option. by @somiaj in fvwmorg/fvwm3#1197
* build: modify release version script by @ThomasAdam in fvwmorg/fvwm3#1201
* meson: do a link test for `locale_charset()` by @Kangie in fvwmorg/fvwm3#1203
* Small RandR fixes by @ThomasAdam in fvwmorg/fvwm3#1207
* setup_visible_names: don't ignore when both set by @ThomasAdam in fvwmorg/fvwm3#1208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates:module Issue is in module code type:enhancement Augmenting an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载