+
Skip to content

[SQL] Refactor FK CandID int(6) to CandidateID int(10) (candidate.ID PK) #9556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 12, 2025
Merged

[SQL] Refactor FK CandID int(6) to CandidateID int(10) (candidate.ID PK) #9556

merged 18 commits into from
Feb 12, 2025

Conversation

jeffersoncasimir
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir commented Feb 11, 2025 •
edited
Loading

Closes #8827

This PR refactors the DB schema to rename every table except candidate's CandID field to CandidateID. This field now instead references candidate.ID, which is now the PK of the table and a int(10) instead of int(6) previously. candidate's CandID field has also been upgraded to an unsigned int(10).

There is a patch that sets all the values of CandidateID of all tables to instead become the corresponding candidate.ID.

The back-end of most modules that used a table with a CandID were refactored to use candidate.CandID and to instead JOIN ON candidate.ID = table_with_CandID_previously.CandidateID.

Left to refactor:

  • Remainder of failing tests
  • Some tools
  • Documentation

@jeffersoncasimir jeffersoncasimir added this to the 27.0.0 milestone Feb 11, 2025
driusan
driusan requested changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in patch

@driusan driusan merged commit af6b5e0 into aces:main Feb 12, 2025
19 checks passed
This was referenced Feb 13, 2025
Open
Closed
Merged
This was referenced Feb 13, 2025
Merged
Open
@jeffersoncasimir jeffersoncasimir mentioned this pull request Feb 14, 2025
Merged
driusan pushed a commit that referenced this pull request Feb 17, 2025
@jeffersoncasimir
[SQL] Fix NULLability of CandidateID FK (#9567)
8b2feec 
Closes #9564 .

This PR addresses the forgotten `NULL`ability annotations, found by
Loris-MRI integration tests.

`NULL`ability should now be identical to how it was prior to the last
patch in #9556
@driusan driusan mentioned this pull request Feb 17, 2025
Merged
@kongtiaowang kongtiaowang mentioned this pull request Feb 28, 2025
Merged
racostas pushed a commit to racostas/Loris that referenced this pull request Mar 12, 2025
modification need after [SQL] Refactor FK CandID int(6) to CandidateI…
f887e5c 
…D int(10) (candidate.ID PK) aces#9556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driusan driusan Awaiting requested review from driusan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

27.0.0

Development

Successfully merging this pull request may close these issues.

CandID should not be an int(6)

2 participants

@jeffersoncasimir @driusan
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载