+
Skip to content

[dataquery] (demographics) Include missing fields from deprecated CouchDB_Import_Demographics. #9566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 13, 2025
Merged

[dataquery] (demographics) Include missing fields from deprecated CouchDB_Import_Demographics. #9566

merged 11 commits into from
Mar 13, 2025

Conversation

racostas
Copy link
Contributor

Brief summary of changes

This PR adds to the new dataquery tool some of the fields missing in demographic information from the deprecated CouchDB_Import_Demographic.

Testing instructions (if applicable)

The new fields should appear now in the demographic section of the DQT.

  1. Please go to the new DQT. MainMenu->Reports->Data Query Tool (Beta)
  2. Try to select the following fields
    • Candidate Identifiers:
      flagged_caveatemptor
      flagged_reason
      flagged_other

image

  • Other parameters:
    ParticipantStatusReason
    ParticipantStatusComments
    DateRegistered
    CurrentStage

image

  1. Now please run the query.
  2. Please check all the fields mentioned are been retrieved, and that the info been shown is correct in every case. ( You may need to spot check various candidates, change values in the candidate_parameter module and rerun the query in dataquery multiple times to properly test all values are properly updated in the query tool)
    image

@racostas racostas added Priority: High PR or issue should be prioritised over others for review and testing Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered Module: candidate_parameters PR or issue related to candidate_parameters module Module: dataquery PR or issue related to (new) dataquery module labels Feb 13, 2025
@racostas racostas added this to the 27.0.0 milestone Feb 13, 2025
@racostas
Copy link
Contributor Author

racostas commented Feb 13, 2025 •
edited
Loading

Pending three variables yet to be included:

  • Failure
  • Comment
  • Session Feedback

@kongtiaowang kongtiaowang added the Passed manual tests PR has been successfully tested by at least one peer label Feb 19, 2025
@racostas
Copy link
Contributor Author

Just added the last variable that I missed. Sorry, thanks !!

@racostas racostas requested a review from driusan February 20, 2025 17:47
@driusan
Copy link
Collaborator

driusan commented Feb 20, 2025

@kongtiaowang GitHub says you added "Passed Manual Tests" before @racostas's commit/comment that he added the last variable.. can you confirm that you tested/reviewed this whole PR? And approve it if so.

kongtiaowang
kongtiaowang approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kongtiaowang
kongtiaowang requested changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SQL] Refactor FK CandID int(6) to CandidateID int(10) (candidate.ID PK) #9556
after this PR got merged, this PR need to modify base on the new changes.

@kongtiaowang kongtiaowang removed the Passed manual tests PR has been successfully tested by at least one peer label Mar 3, 2025
driusan
driusan requested changes Mar 12, 2025
View reviewed changes
@kongtiaowang kongtiaowang added the Passed manual tests PR has been successfully tested by at least one peer label Mar 12, 2025
kongtiaowang
kongtiaowang approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit a6407ee into aces:main Mar 13, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in LORIS RoadMap Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

@driusan driusan Awaiting requested review from driusan

Assignees

@kongtiaowang kongtiaowang

Labels

Module: candidate_parameters PR or issue related to candidate_parameters module Module: dataquery PR or issue related to (new) dataquery module Passed manual tests PR has been successfully tested by at least one peer Priority: High PR or issue should be prioritised over others for review and testing Proposal PR or issue suggesting an improvement that can be accepted, rejected or altered

Projects

LORIS RoadMap
Status: Done

Milestone

27.0.0

Development

Successfully merging this pull request may close these issues.

[dataquery] dataquery module should include all data from CouchDB_Import_Demographics

3 participants

@racostas @driusan @kongtiaowang
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载