+
Skip to content

Conversation

jeffersoncasimir
Copy link
Contributor

Closes #9564 .

This PR addresses the forgotten NULLability annotations, found by Loris-MRI integration tests.

NULLability should now be identical to how it was prior to the last patch in #9556

@jeffersoncasimir jeffersoncasimir force-pushed the 2025_02_14_fix_nullability_candidateid_fk branch from 651255c to 33825b0 Compare February 14, 2025 16:21
Copy link
Contributor

@maximemulder maximemulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was fast ! I checked manually that the NOT NULL and DEFAULT NULL annotations match that of before the refactor, and that the annotations in the schema match that of the patch. Everything looks in order to me. Nice catch for the defaults too.

@driusan driusan merged commit 8b2feec into aces:main Feb 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CandidateID missing NOT NULL annotations

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载