ignore files in gitignore also for pipeline_if_empty_null lint test #3722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfy133
approved these changes
Aug 23, 2025
mashehu
approved these changes
Aug 24, 2025
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mashehu
reviewed
Aug 25, 2025
| with open(Path(wf_path, ".gitignore")) as f: | ||
| lines = f.read().splitlines() | ||
| ignore = [line for line in lines if line and not line.startswith("#")] | ||
| except FileNotFoundError: |
There was a problem hiding this comment.
Do we have a unit test for this case?
There was a problem hiding this comment.
we don't! I can add it with another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue found with nf-core/mag where the lint test was stuck trying to open too many files https://nfcore.slack.com/archives/CE5LG7WMB/p1755845835047829