General: add pytest for get_wf_files #3725
Open
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nf-core-bot update textual snapshots |
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mashehu
approved these changes
Aug 26, 2025
| with mock.patch("nf_core.utils.set_wd", side_effect=Exception("mocked exception")): | ||
| with pytest.raises(Exception): | ||
| with nf_core.utils.set_wd(self.tmp_dir): | ||
| assert wd_before_context == Path().resolve() |
There was a problem hiding this comment.
I don't understand this assertion. Doesn't this mean that the wd is the same as before and set_wd didn't do anything?
There was a problem hiding this comment.
Yes, I think this is what the test is supposed to do, based on the name "revert_on_raise"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests messing from #3722 (review)
I also fixed a test which was not testing what it was intended to.