-
Notifications
You must be signed in to change notification settings - Fork 206
Issues/3466 Move away from Gitpod #3569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JulianFlesch
wants to merge
50
commits into
nf-core:dev
Choose a base branch
from
JulianFlesch:issues/3466-gitpod
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−103
Draft
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
80b0182
Renaming Dockerfile and location. Changing to building the Dockerfile…
JulianFlesch 7a8cebd
change Container user. Change base Image for devcontainer
JulianFlesch 5fd706a
Remove installation of apptainer via apt-get because of 404 from ppa
JulianFlesch 0d6e6a5
Create unprivileged user
JulianFlesch be2996e
Change git workflow for container creation and use the correct contai…
JulianFlesch 53dd172
Update instruction to build locally for testing
JulianFlesch dd6ddc3
[automated] Update CHANGELOG.md
nf-core-bot 0c3a21d
Merge branch 'issues/3466-gitpod' of github.com:JulianFlesch/nf-core-…
JulianFlesch 464d3bd
More descriptive changelog entry
JulianFlesch 2ee5fc1
Change base Image
JulianFlesch 776b2c8
Change back to using gitpod user
JulianFlesch a5c6644
Remove comment
JulianFlesch c77a469
WIP: build container locally instead of pulling. Change to gitpod use…
JulianFlesch 36e5f7a
Rename pushed container to nf-core/devcontainer
JulianFlesch 4f8a2c0
Remove gitpod.yml from template
JulianFlesch c225114
Remove .gitpod.yml
JulianFlesch 56962f2
Merge branch 'dev' into issues/3466-gitpod
JulianFlesch f525657
Remove local container building
JulianFlesch e0e6d97
Change base image tag
JulianFlesch 923d99d
re-add comments
JulianFlesch b5e7487
Add latest tag explicitly
JulianFlesch 8785edb
Test seqera container base image
JulianFlesch cccb21c
update comments. todo
JulianFlesch 774b4cd
Rename to reflect base image
JulianFlesch 0091a34
WIP: devcontainer with docker-in-docker feature
JulianFlesch 875d661
Add seqera url as comment
JulianFlesch 6a2c92d
Overwrite base image entrypoint. Add non-privileged user.
JulianFlesch 77a8357
Clean up
JulianFlesch 0aa49b3
Make user privileged when running container
JulianFlesch e9fa6df
Change to non-root user 'vscode' from base image. Try running without…
JulianFlesch 552b0ff
Run privileged
JulianFlesch dd021d0
Change nf-core install to have dev dependencies and --editable set
JulianFlesch 64e86d5
Install pre-commit hooks in image
JulianFlesch 9eda307
Remove redundant post-create installation of nf-core and pre-commit h…
JulianFlesch d0fea24
Remove postCreateCommand. Remove Privileged
JulianFlesch d974952
Fix pre-commit install cmd
JulianFlesch 3216521
Remove more redundant conda packages
JulianFlesch e400076
Chown nf-core dir when copying. Chown conda folder only when using conda
JulianFlesch 7e1aba2
Remove unneeded dependencies and those already in base image
JulianFlesch 14a3e95
Fix command end
JulianFlesch 6d284fb
WIP: Comment out section adding lots of size to the image
JulianFlesch 5d8503b
Use vscode user everywhere
JulianFlesch 08d29fc
Re-introduce nextflow update, nf-core dev, and commit hooks install
JulianFlesch c5dd2d2
Use nextflow/training base image to share nextflow, conda installation
JulianFlesch 0fa9993
Add setup.sh to fix run issues with nf/training img. Move latest tool…
JulianFlesch 2eceaf7
change ownership of nextflow installation location
JulianFlesch 4b825df
Update comment. Change layer order
JulianFlesch d7854ff
Update template devcontainer
JulianFlesch 3dff96d
Remove testing Dockerfiles
JulianFlesch 4e9d298
Merge branch 'dev' into issues/3466-gitpod
JulianFlesch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#!/usr/bin/env bash | ||
|
||
# Customise the terminal command prompt | ||
printf "export PS1='\\[\\e[3;36m\\]\${PWD#/workspaces/} ->\\[\\e[0m\\] '\n" >> $HOME/.bashrc | ||
export PS1='\[\e[3;36m\]${PWD#/workspaces/} ->\[\e[0m\] ' | ||
|
||
# Update Nextflow | ||
nextflow self-update | ||
|
||
# Install nf-core tools in editable mode | ||
python -m pip install -r requirements-dev.txt -e . --no-cache-dir | ||
|
||
# Install pre-commit hooks | ||
pre-commit install --install-hooks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Test build locally before making a PR (from project root directory) | ||
# docker build . -t devcontainer:local -f nf_core/devcontainer/devcontainer.Dockerfile | ||
|
||
# Uses mcr.microsoft.com/devcontainers/base:ubuntu | ||
FROM ghcr.io/nextflow-io/training:latest | ||
|
||
# Change user to vscode | ||
USER vscode | ||
|
||
# Add the nf-core source files to the image | ||
COPY --chown=vscode:vscode . /usr/src/nf_core | ||
WORKDIR /usr/src/nf_core | ||
|
||
# Change ownership of conda and nextflow bin | ||
RUN sudo chown -R vscode:vscode /usr/local/bin/ && \ | ||
sudo chown -R vscode:vscode /opt/conda | ||
|
||
# Install apptainer via conda | ||
RUN conda install --quiet --yes --update-all --name base \ | ||
conda-forge::apptainer>=1.4.1 && \ | ||
conda clean --all --force-pkgs-dirs --yes |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#!/usr/bin/env bash | ||
|
||
# Customise the terminal command prompt | ||
printf "export PS1='\\[\\e[3;36m\\]\${PWD#/workspaces/} ->\\[\\e[0m\\] '\n" >> $HOME/.bashrc | ||
export PS1='\[\e[3;36m\]${PWD#/workspaces/} ->\[\e[0m\] ' | ||
|
||
# Update Nextflow | ||
nextflow self-update |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pin the version!