Extended the hook_url functionality to Slack #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1829 +/- ##
=======================================
Coverage 63.74% 63.74%
=======================================
Files 41 41
Lines 4913 4913
=======================================
Hits 3132 3132
Misses 1781 1781 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
matthdsm
reviewed
Sep 16, 2022
|
Love it, just left one small comment |
|
|
|
Is this considered to be superseded by https://github.com/Midnighter/nf-slack ? |
23d0d19 to
33a09af
Compare
matthdsm
approved these changes
Nov 16, 2022
|
Thank you ! |
|
Please add documentation about this nf-core/website#1455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Got very interested in what @matthdsm did in #1798 . This is a small extension to support Slack as well, since Slack doesn't understand adaptive cards.
Here is how the notifications look like:
The JSON has a very long and tricky line where I try to improve the look-and-feel of the pipeline configuration:
Note: I am using the legacy "attachments" method of the Slack API, rather than the now-recommended Block Kit method, because I couldn't find how to make the latter put some colour. I think one has to immediately know whether it failed or not, and the colour is faster to recognise than the text itself.
PR checklist
CHANGELOG.mdis updateddocsis updated