-
Notifications
You must be signed in to change notification settings - Fork 206
dev
-> master
for v1.14 release
#1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Minor tweaks
Modules lint - exit code 1 if we have failures
Increased test coverage
update module commands with new format
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Adjust linting
fixed template for "modules create"
Interactive prompts for 'download' and 'launch'
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
Module install folder name based on source repo name
Quick start nf version
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright this gets the go from my side 🚀
Looking all good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve as it is.
I think there is some tiny typos.
One inconsistency between Nextflow version that should be the same.
And I think we can improve the tools.Dockerfile
, but that can be done in the next release
Co-authored-by: Maxime U. Garcia <max.u.garcia@gmail.com>
Fix review comments from @maxulysse in #1066
dev
->master
for v1.14 release