Quick start nf version #1064
Quick start nf version #1064
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1064 +/- ##
==========================================
- Coverage 73.49% 72.23% -1.27%
==========================================
Files 36 36
Lines 4396 4520 +124
==========================================
+ Hits 3231 3265 +34
- Misses 1165 1255 +90
Continue to review full report at Codecov.
|
nf_core/bump_version.py
Outdated
| @@ -145,7 +145,7 @@ def bump_nextflow_version(pipeline_obj, new_version): | |||
| pipeline_obj, | |||
| [ | |||
| ( | |||
| r"nxf_ver: \[[\'\"]?{}[\'\"]?, ''\]".format(current_version.replace(".", r"\.")), | |||
| r"nxf_ver: \[[\'\"]?{}[\'\"]?, [\'\"]?[\'\"]?\]".format(current_version.replace(".", r"\.")), | |||
There was a problem hiding this comment.
What is this doing? Allowing either '' or ""?
Do you need the ? characters? I feel like this regex would also match ['foo', ] which doesn't seem right..
There was a problem hiding this comment.
Yeah I plead guilty of copying that part of the regexes from other locations where it should replace allow ' or "
Then let's remove the question marks at the other locations as well I guess? as there should always be brackets I guess
There was a problem hiding this comment.
removed the question marks now
There was a problem hiding this comment.
Nice, looks good! Don't think that it mattered much anyway so no need to go hunting elsewhere 👍🏻
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
This PR adds a nextflow version to the Quick start section in the
README.mdand adjusts thebump-versioncommand