这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@nmoinvaz
Copy link
Member

@nmoinvaz nmoinvaz commented Jun 25, 2022

From discussion in #1289.

@nmoinvaz nmoinvaz added the Compatibility API/ABI Compatibility issue label Jun 25, 2022
@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #1306 (4039f9d) into develop (2174201) will increase coverage by 0.96%.
The diff coverage is n/a.

❗ Current head 4039f9d differs from pull request most recent head 3705234. Consider uploading reports for the commit 3705234 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1306      +/-   ##
===========================================
+ Coverage    86.51%   87.48%   +0.96%     
===========================================
  Files          125      125              
  Lines        10670    10658      -12     
  Branches      2664     2628      -36     
===========================================
+ Hits          9231     9324      +93     
+ Misses        1081      976     -105     
  Partials       358      358              
Flag Coverage Δ
macos_clang 32.60% <ø> (ø)
macos_gcc 73.91% <ø> (+0.03%) ⬆️
ubuntu_clang 85.20% <ø> (+0.14%) ⬆️
ubuntu_clang_debug 84.86% <ø> (+0.01%) ⬆️
ubuntu_clang_inflate_allow_invalid_dist 86.43% <ø> (+1.52%) ⬆️
ubuntu_clang_inflate_strict 85.16% <ø> (+<0.01%) ⬆️
ubuntu_clang_mmap 85.35% <ø> (+<0.01%) ⬆️
ubuntu_clang_pigz 40.10% <ø> (+0.02%) ⬆️
ubuntu_clang_pigz_no_optim 41.52% <ø> (+0.03%) ⬆️
ubuntu_clang_pigz_no_threads 39.69% <ø> (+0.02%) ⬆️
ubuntu_clang_reduced_mem 85.59% <ø> (+<0.01%) ⬆️
ubuntu_gcc 75.74% <ø> (+0.04%) ⬆️
ubuntu_gcc_aarch64 77.46% <ø> (+0.04%) ⬆️
ubuntu_gcc_aarch64_compat_no_opt 75.81% <ø> (+0.05%) ⬆️
ubuntu_gcc_aarch64_no_acle 76.31% <ø> (+0.05%) ⬆️
ubuntu_gcc_aarch64_no_neon 76.35% <ø> (+0.04%) ⬆️
ubuntu_gcc_armhf 77.42% <ø> (+0.04%) ⬆️
ubuntu_gcc_armhf_compat_no_opt 75.64% <ø> (+0.04%) ⬆️
ubuntu_gcc_armhf_no_acle 77.42% <ø> (+0.05%) ⬆️
ubuntu_gcc_armhf_no_neon 77.31% <ø> (+0.04%) ⬆️
ubuntu_gcc_armsf 77.18% <ø> (+0.04%) ⬆️
ubuntu_gcc_armsf_compat_no_opt 75.35% <ø> (+0.07%) ⬆️
ubuntu_gcc_benchmark 73.97% <ø> (-0.16%) ⬇️
ubuntu_gcc_compat_no_opt 76.96% <ø> (+0.02%) ⬆️
ubuntu_gcc_compat_sprefix 74.09% <ø> (+0.03%) ⬆️
ubuntu_gcc_m32 73.61% <ø> (+0.03%) ⬆️
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 74.91% <ø> (-0.02%) ⬇️
ubuntu_gcc_no_ctz 74.99% <ø> (+0.03%) ⬆️
ubuntu_gcc_no_ctzll 75.02% <ø> (+0.03%) ⬆️
ubuntu_gcc_no_pclmulqdq 74.14% <ø> (-0.01%) ⬇️
ubuntu_gcc_no_sse2 75.11% <ø> (+0.04%) ⬆️
ubuntu_gcc_no_sse4 74.81% <ø> (+0.04%) ⬆️
ubuntu_gcc_o1 74.49% <ø> (+0.04%) ⬆️
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.16% <ø> (+0.14%) ⬆️
ubuntu_gcc_pigz_aarch64 39.15% <ø> (-0.07%) ⬇️
ubuntu_gcc_ppc 73.69% <ø> (+0.03%) ⬆️
ubuntu_gcc_ppc64 74.56% <ø> (+0.03%) ⬆️
ubuntu_gcc_ppc64le 74.53% <ø> (+0.03%) ⬆️
ubuntu_gcc_ppc_no_power8 74.62% <ø> (+0.03%) ⬆️
ubuntu_gcc_s390x 74.95% <ø> (+0.03%) ⬆️
ubuntu_gcc_s390x_dfltcc 72.18% <ø> (+0.03%) ⬆️
ubuntu_gcc_s390x_dfltcc_compat 73.74% <ø> (+0.04%) ⬆️
ubuntu_gcc_s390x_no_crc32 74.73% <ø> (+0.03%) ⬆️
ubuntu_gcc_sparc64 74.84% <ø> (+0.03%) ⬆️
ubuntu_gcc_sprefix 73.75% <ø> (+0.03%) ⬆️
win64_gcc ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deflate.c 83.20% <ø> (-0.13%) ⬇️
inftrees.c 100.00% <ø> (ø)
zutil_p.h 77.77% <0.00%> (-22.23%) ⬇️
test/test_compare256.cc 55.55% <0.00%> (-3.71%) ⬇️
adler32_p.h 96.42% <0.00%> (-3.58%) ⬇️
arch/x86/adler32_sse42.c 98.46% <0.00%> (-1.54%) ⬇️
test/test_deflate_concurrency.cc 89.01% <0.00%> (-0.12%) ⬇️
uncompr.c 91.30% <0.00%> (ø)
test/minideflate.c 58.57% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2174201...3705234. Read the comment docs.

@nmoinvaz nmoinvaz force-pushed the improvements/version-fork branch from 4039f9d to 3705234 Compare June 30, 2022 18:24
@nmoinvaz
Copy link
Member Author

Rebased.

@Dead2 Dead2 merged commit 1532af4 into zlib-ng:develop Aug 15, 2022
@Dead2 Dead2 mentioned this pull request Dec 27, 2022
Dead2 added a commit that referenced this pull request Mar 7, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Dead2 added a commit that referenced this pull request Mar 17, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compatibility API/ABI Compatibility issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants