这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@phprus
Copy link
Contributor

@phprus phprus commented May 12, 2022

If zlib-ng is added to the CMake project via add_subdirectory then the ${CMAKE_CURRENT_BINARY_DIR}/Testing/Temporary directory may not exist when the tests are run.

CMake creates a Testing/Temporary directory only for the top project (${CMAKE_BINARY_DIR}/Testing/Temporary).

Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1273 (25b6c44) into develop (41d6739) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1273   +/-   ##
========================================
  Coverage    87.17%   87.17%           
========================================
  Files          117      117           
  Lines        10249    10249           
  Branches      2587     2587           
========================================
  Hits          8935     8935           
  Misses         977      977           
  Partials       337      337           
Flag Coverage Δ
macos_clang 33.33% <ø> (ø)
macos_gcc 74.95% <ø> (ø)
ubuntu_clang 87.42% <ø> (ø)
ubuntu_clang_debug 86.96% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 87.12% <ø> (ø)
ubuntu_clang_inflate_strict 87.37% <ø> (ø)
ubuntu_clang_mmap 87.56% <ø> (ø)
ubuntu_clang_pigz 40.95% <ø> (ø)
ubuntu_clang_pigz_no_optim 41.14% <ø> (ø)
ubuntu_clang_pigz_no_threads 40.53% <ø> (ø)
ubuntu_clang_reduced_mem 86.97% <ø> (ø)
ubuntu_gcc 77.01% <ø> (ø)
ubuntu_gcc_aarch64 77.31% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.36% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 76.21% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 76.09% <ø> (ø)
ubuntu_gcc_armhf 77.32% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 75.28% <ø> (ø)
ubuntu_gcc_armhf_no_acle 77.34% <ø> (ø)
ubuntu_gcc_armhf_no_neon 77.10% <ø> (ø)
ubuntu_gcc_armsf 77.23% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 74.95% <ø> (ø)
ubuntu_gcc_benchmark 75.00% <ø> (ø)
ubuntu_gcc_compat_no_opt 76.50% <ø> (ø)
ubuntu_gcc_compat_sprefix 75.10% <ø> (ø)
ubuntu_gcc_m32 74.84% <ø> (ø)
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 76.66% <ø> (ø)
ubuntu_gcc_no_ctz 74.76% <ø> (ø)
ubuntu_gcc_no_ctzll 74.80% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 75.44% <ø> (+0.79%) ⬆️
ubuntu_gcc_no_sse2 76.72% <ø> (+0.76%) ⬆️
ubuntu_gcc_no_sse4 75.50% <ø> (-0.76%) ⬇️
ubuntu_gcc_o1 75.97% <ø> (+0.76%) ⬆️
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.90% <ø> (ø)
ubuntu_gcc_pigz_aarch64 39.42% <ø> (-0.03%) ⬇️
ubuntu_gcc_ppc 73.57% <ø> (ø)
ubuntu_gcc_ppc64 74.33% <ø> (ø)
ubuntu_gcc_ppc64le 74.31% <ø> (ø)
ubuntu_gcc_ppc_no_power8 74.52% <ø> (ø)
ubuntu_gcc_s390x 74.73% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 72.09% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat 73.63% <ø> (ø)
ubuntu_gcc_s390x_no_crc32 74.51% <ø> (ø)
ubuntu_gcc_sparc64 74.62% <ø> (ø)
ubuntu_gcc_sprefix 74.89% <ø> (ø)
win64_gcc 73.96% <ø> (ø)
win64_gcc_compat_no_opt 73.98% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d6739...25b6c44. Read the comment docs.

Copy link
Member

@nmoinvaz nmoinvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@Dead2 Dead2 merged commit 8730b9a into zlib-ng:develop May 15, 2022
@Dead2 Dead2 mentioned this pull request Dec 27, 2022
Dead2 added a commit that referenced this pull request Mar 7, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Dead2 added a commit that referenced this pull request Mar 17, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants