这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@mtl1979
Copy link
Collaborator

@mtl1979 mtl1979 commented Jun 17, 2022

Also move include for stdint.h/stdarg.h out of zconf.h/zconf-ng.h as stdint.h must be included first.

See #1296

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1297 (010c04a) into develop (54ea239) will decrease coverage by 1.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1297      +/-   ##
===========================================
- Coverage    87.60%   86.55%   -1.06%     
===========================================
  Files          124      124              
  Lines        10537    10537              
  Branches      2624     2624              
===========================================
- Hits          9231     9120     -111     
- Misses         952     1061     +109     
- Partials       354      356       +2     
Flag Coverage Δ
macos_clang 33.33% <ø> (ø)
macos_gcc 73.80% <ø> (ø)
ubuntu_clang 85.40% <ø> (ø)
ubuntu_clang_debug 85.04% <ø> (ø)
ubuntu_clang_inflate_allow_invalid_dist 85.11% <ø> (ø)
ubuntu_clang_inflate_strict 85.35% <ø> (-1.52%) ⬇️
ubuntu_clang_mmap 85.54% <ø> (+0.13%) ⬆️
ubuntu_clang_pigz 40.21% <ø> (ø)
ubuntu_clang_pigz_no_optim 41.66% <ø> (ø)
ubuntu_clang_pigz_no_threads 39.80% <ø> (ø)
ubuntu_clang_reduced_mem 85.79% <ø> (ø)
ubuntu_gcc 75.65% <ø> (+0.06%) ⬆️
ubuntu_gcc_aarch64 77.50% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.62% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 76.30% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 76.20% <ø> (ø)
ubuntu_gcc_armhf 77.52% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 75.60% <ø> (ø)
ubuntu_gcc_armhf_no_acle 77.52% <ø> (ø)
ubuntu_gcc_armhf_no_neon 77.30% <ø> (ø)
ubuntu_gcc_armsf 77.17% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 75.27% <ø> (ø)
ubuntu_gcc_benchmark 73.86% <ø> (-0.20%) ⬇️
ubuntu_gcc_compat_no_opt 76.83% <ø> (ø)
ubuntu_gcc_compat_sprefix 73.98% <ø> (-0.15%) ⬇️
ubuntu_gcc_m32 73.60% <ø> (-0.15%) ⬇️
ubuntu_gcc_mingw_i686 0.00% <ø> (ø)
ubuntu_gcc_mingw_x86_64 0.00% <ø> (ø)
ubuntu_gcc_no_avx2 74.80% <ø> (-0.07%) ⬇️
ubuntu_gcc_no_ctz 74.86% <ø> (ø)
ubuntu_gcc_no_ctzll 74.89% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 74.06% <ø> (ø)
ubuntu_gcc_no_sse2 75.01% <ø> (ø)
ubuntu_gcc_no_sse4 74.70% <ø> (ø)
ubuntu_gcc_o1 74.38% <ø> (ø)
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.17% <ø> (+0.02%) ⬆️
ubuntu_gcc_pigz_aarch64 39.28% <ø> (-0.06%) ⬇️
ubuntu_gcc_ppc 73.66% <ø> (ø)
ubuntu_gcc_ppc64 74.43% <ø> (ø)
ubuntu_gcc_ppc64le 74.41% <ø> (ø)
ubuntu_gcc_ppc_no_power8 74.61% <ø> (ø)
ubuntu_gcc_s390x 74.82% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 72.21% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat 73.75% <ø> (ø)
ubuntu_gcc_s390x_no_crc32 74.60% <ø> (ø)
ubuntu_gcc_sparc64 74.71% <ø> (ø)
ubuntu_gcc_sprefix 73.64% <ø> (ø)
win64_gcc 73.84% <ø> (ø)
win64_gcc_compat_no_opt 74.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arch/x86/adler32_avx512_vnni.c 0.00% <0.00%> (-87.61%) ⬇️
adler32_p.h 96.42% <0.00%> (-3.58%) ⬇️
arch/x86/adler32_avx2_tpl.h 97.87% <0.00%> (-2.13%) ⬇️
arch/x86/adler32_sse42.c 98.46% <0.00%> (-1.54%) ⬇️
functable.c 77.88% <0.00%> (-0.97%) ⬇️
deflate.c 83.20% <0.00%> (-0.13%) ⬇️
uncompr.c 91.30% <0.00%> (ø)
arch/x86/adler32_avx512_tpl.h 100.00% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ea239...010c04a. Read the comment docs.

@nmoinvaz nmoinvaz added the Compatibility API/ABI Compatibility issue label Jun 17, 2022
@mtl1979 mtl1979 force-pushed the z_crc_t branch 2 times, most recently from f474be6 to 6f1cbd2 Compare June 17, 2022 15:39
Copy link
Member

@nmoinvaz nmoinvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dead2 Dead2 merged commit ff9162c into zlib-ng:develop Jun 19, 2022
@Dead2 Dead2 mentioned this pull request Dec 27, 2022
Dead2 added a commit that referenced this pull request Mar 7, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Dead2 added a commit that referenced this pull request Mar 17, 2023
Changes since 2.0.6:
- Fix CVE-2022-37434 #1328
- Fix chunkmemset #1196
- Fix deflateBound too small #1236
- Fix Z_SOLO #1263
- Fix ACLE variant of crc32 #1274
- Fix inflateBack #1311
- Fix deflate_quick windowsize #1431
- Fix DFLTCC bugs related to adler32 #1349 and #1390
- Fix warnings #1194 #1312 #1362
- MacOS build fix #1198
- Add invalid windowBits handling #1293
- Support for Force TZCNT #1186
- Support for aligned_alloc() #1360
- Minideflate improvements #1175 #1238
- Dont use unaligned access for memcpy #1309
- Build system #1209 #1233 #1267 #1273 #1278 #1292 #1316 #1318 #1365
- Test improvements #1208 #1227 #1241 #1353
- Cleanup #1266
- Documentation #1205 #1359
- Misc improvements #1294 #1297 #1306 #1344 #1348
- Backported zlib fixes
- Backported CI workflows from Develop branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compatibility API/ABI Compatibility issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants