这是indexloc提供的服务,不要输入任何密码
Skip to content

fix docs build failure and a bug in a2c/ppo optimizer #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2021
Merged

Conversation

Trinkle23897
Copy link
Collaborator

@Trinkle23897 Trinkle23897 commented Aug 29, 2021

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #428 (20db2de) into master (291be08) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   94.74%   94.82%   +0.07%     
==========================================
  Files          58       58              
  Lines        3807     3807              
==========================================
+ Hits         3607     3610       +3     
+ Misses        200      197       -3     
Flag Coverage Δ
unittests 94.82% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelfree/a2c.py 96.87% <ø> (ø)
tianshou/policy/modelfree/ppo.py 93.93% <ø> (ø)
tianshou/policy/modelfree/trpo.py 93.44% <0.00%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291be08...20db2de. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit e4f4f0e into master Aug 29, 2021
@Trinkle23897 Trinkle23897 deleted the dev branch August 29, 2021 18:07
@Trinkle23897 Trinkle23897 linked an issue Aug 29, 2021 that may be closed by this pull request
8 tasks
@Trinkle23897 Trinkle23897 mentioned this pull request Sep 15, 2021
8 tasks
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
* fix rtfd build

* list + list -> set.union

* change seed of test_qrdqn

* add py39 test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimizer double update ? deprecation soon
2 participants