-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
- I have marked all applicable categories:
- exception-raising bug
- RL algorithm bug
- documentation request (i.e. "X is missing from the documentation.")
- new feature request
- I have visited the source website
- I have searched through the issue tracker for duplicates
- I have mentioned version numbers, operating system and environment, where applicable:
import tianshou, torch, numpy, sys print(tianshou.__version__, torch.__version__, numpy.__version__, sys.version, sys.platform)
Hey, I just want to say it may be needed a set()
wrapping the list of params in
tianshou/test/discrete/test_ppo.py
Line 79 in c198761
list(actor.parameters()) + list(critic.parameters()), lr=args.lr) |
this is related to the warining
UserWarning: optimizer contains a parameter group with duplicate parameters; in future, this will cause an error; see github.com/pytorch/pytorch/issues/40967 for more information super(Adam, self).__init__(params, defaults)
The current version of the PPO test is updating some parameters twice, which could be the intended behavior but it won't be possible in the future.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working