这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@licy183
Copy link
Member

@licy183 licy183 commented Jul 27, 2025

No description provided.

@robertkirkman robertkirkman self-requested a review July 27, 2025 23:09
TERMUX_PKG_MAINTAINER="@licy183"
_MAJOR_VERSION=3.10
TERMUX_PKG_VERSION=7.3.17
_MAJOR_VERSION=3.11
Copy link
Member

@robertkirkman robertkirkman Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have three questions, which I will try to explain as concisely as possible to avoid making a message too long:

  • I have a different implementation of 9997-do-not-cffi-dlopen-when-compiling-sqlite3.diff that might be more reliable long-term because my way does not hardcode any reference to "sqlite", and could therefore theoretically work if the same error would ever happen to any other thing that isn't sqlite.

    • Question: Would you like to discuss the possibility of using that, or do you prefer the current 9997-do-not-cffi-dlopen-when-compiling-sqlite3.diff?
  • Earlier today, you changed [ "$TERMUX_PACKAGE_FORMAT" != "pacman" ] in build.sh to [ "$TERMUX_PACKAGE_FORMAT" = "debian" ], but that is still present in pypy3-tests.subpackage.sh and pypy3-tkinter.subpackage.sh

    • Question: Did you want to change that throughout the package, or is it fine as-is?
  • You have increased the $_MAJOR_VERSION, but you did not add anything to the postinst to clean up the $PREFIX/opt/pypy3/lib/pypy3.9 folder after it is upgraded to the package that instead contains $PREFIX/opt/pypy3/lib/pypy3.10 or $PREFIX/opt/pypy3/lib/pypy3.11, so this folder remains after the pypy3 package is upgraded to the newer releases. I have an implementation of a postinst script for pypy3 that can successfully clean up the __pycache__ folders of previously-installed pypy3 packages of all$_MAJOR_VERSIONs.

    • Question: Would you like to discuss the possibility of using that, or are you fine with the way it is currently?
Image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer 9997-do-not-cffi-dlopen-when-compiling-sqlite3.diff, but you can commit your changes of other parts.

Copy link
Member

@robertkirkman robertkirkman Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to push the commits into this branch, but I believe I do not have GitHub permission to do that, so I will wait until after you merge this, and then after that I will open my own PR for the changes, assuming that is what you prefer to happen.

Here are the commits in case you want to see the changes I am planning to add: bump-pypy3...robertkirkman:termux-packages:bump-pypy3

@licy183
Copy link
Member Author

licy183 commented Aug 11, 2025

I'll merge this first. @robertkirkman Please submit your patches into another PR. Thanks!

@licy183 licy183 merged commit 9865d95 into master Aug 11, 2025
13 checks passed
@licy183 licy183 deleted the bump-pypy3 branch August 11, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants