-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
pypy3: bump to 7.3.19 #25487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pypy3: bump to 7.3.19 #25487
Conversation
| TERMUX_PKG_MAINTAINER="@licy183" | ||
| _MAJOR_VERSION=3.10 | ||
| TERMUX_PKG_VERSION=7.3.17 | ||
| _MAJOR_VERSION=3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have three questions, which I will try to explain as concisely as possible to avoid making a message too long:
-
I have a different implementation of
9997-do-not-cffi-dlopen-when-compiling-sqlite3.diffthat might be more reliable long-term because my way does not hardcode any reference to "sqlite", and could therefore theoretically work if the same error would ever happen to any other thing that isn't sqlite.- Question: Would you like to discuss the possibility of using that, or do you prefer the current
9997-do-not-cffi-dlopen-when-compiling-sqlite3.diff?
- Question: Would you like to discuss the possibility of using that, or do you prefer the current
-
Earlier today, you changed
[ "$TERMUX_PACKAGE_FORMAT" != "pacman" ]inbuild.shto[ "$TERMUX_PACKAGE_FORMAT" = "debian" ], but that is still present inpypy3-tests.subpackage.shandpypy3-tkinter.subpackage.sh- Question: Did you want to change that throughout the package, or is it fine as-is?
-
You have increased the
$_MAJOR_VERSION, but you did not add anything to thepostinstto clean up the$PREFIX/opt/pypy3/lib/pypy3.9folder after it is upgraded to the package that instead contains$PREFIX/opt/pypy3/lib/pypy3.10or$PREFIX/opt/pypy3/lib/pypy3.11, so this folder remains after thepypy3package is upgraded to the newer releases. I have an implementation of apostinstscript forpypy3that can successfully clean up the__pycache__folders of previously-installedpypy3packages of all$_MAJOR_VERSIONs.- Question: Would you like to discuss the possibility of using that, or are you fine with the way it is currently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer 9997-do-not-cffi-dlopen-when-compiling-sqlite3.diff, but you can commit your changes of other parts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to push the commits into this branch, but I believe I do not have GitHub permission to do that, so I will wait until after you merge this, and then after that I will open my own PR for the changes, assuming that is what you prefer to happen.
Here are the commits in case you want to see the changes I am planning to add: bump-pypy3...robertkirkman:termux-packages:bump-pypy3
|
I'll merge this first. @robertkirkman Please submit your patches into another PR. Thanks! |
No description provided.