-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
pypy3: bump to 7.3.19 #25487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
pypy3: bump to 7.3.19 #25487
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| https://github.com/pypy/pypy/commit/8708da3ee0783873a8897654b56ac05d7e9b688d | ||
|
|
||
| --- a/rpython/translator/c/src/precommondefs.h | ||
| +++ b/rpython/translator/c/src/precommondefs.h | ||
| @@ -11,7 +11,7 @@ | ||
| /* Define on Darwin to activate all library features */ | ||
| #define _DARWIN_C_SOURCE 1 | ||
| /* These must be set to 64 to enable large file support on 32-bit systems. */ | ||
| -#if defined(i386) || defined(__i386__) || defined(__i386) || defined(_M_IX86) | ||
| +#if defined(i386) || defined(__i386__) || defined(__i386) || defined(_M_IX86) || defined(__arm__) | ||
| #define _FILE_OFFSET_BITS 64 | ||
| #define _LARGEFILE_SOURCE 1 | ||
| #endif | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have three questions, which I will try to explain as concisely as possible to avoid making a message too long:
I have a different implementation of
9997-do-not-cffi-dlopen-when-compiling-sqlite3.diffthat might be more reliable long-term because my way does not hardcode any reference to "sqlite", and could therefore theoretically work if the same error would ever happen to any other thing that isn't sqlite.9997-do-not-cffi-dlopen-when-compiling-sqlite3.diff?Earlier today, you changed
[ "$TERMUX_PACKAGE_FORMAT" != "pacman" ]inbuild.shto[ "$TERMUX_PACKAGE_FORMAT" = "debian" ], but that is still present inpypy3-tests.subpackage.shandpypy3-tkinter.subpackage.shYou have increased the
$_MAJOR_VERSION, but you did not add anything to thepostinstto clean up the$PREFIX/opt/pypy3/lib/pypy3.9folder after it is upgraded to the package that instead contains$PREFIX/opt/pypy3/lib/pypy3.10or$PREFIX/opt/pypy3/lib/pypy3.11, so this folder remains after thepypy3package is upgraded to the newer releases. I have an implementation of apostinstscript forpypy3that can successfully clean up the__pycache__folders of previously-installedpypy3packages of all$_MAJOR_VERSIONs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer
9997-do-not-cffi-dlopen-when-compiling-sqlite3.diff, but you can commit your changes of other parts.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to push the commits into this branch, but I believe I do not have GitHub permission to do that, so I will wait until after you merge this, and then after that I will open my own PR for the changes, assuming that is what you prefer to happen.
Here are the commits in case you want to see the changes I am planning to add: bump-pypy3...robertkirkman:termux-packages:bump-pypy3