这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(main/pypy3): fix build with NDK r28c #25675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2025
Merged

fix(main/pypy3): fix build with NDK r28c #25675

merged 4 commits into from
Aug 12, 2025

Conversation

@robertkirkman
Copy link
Member

@robertkirkman robertkirkman commented Aug 11, 2025 •
edited
Loading

@robertkirkman robertkirkman requested a review from licy183 as a code owner August 11, 2025 15:49
@robertkirkman robertkirkman marked this pull request as draft August 11, 2025 17:12
@robertkirkman
chore(main/pypy3): remove the instance of -Wno-discarded-qualifiers…
a95d9b1 
… because it creates excessive messages in the build log
@robertkirkman
fix(main/pypy3): fix build with NDK r28c
5b6e1da 
- This is like termux#25627, but for the package `pypy3` instead of the package `libllvm`
@robertkirkman robertkirkman changed the title fix(main/pypy3): create postinst to clean up all runtime-generated files of the previous pypy3 installations fix(main/pypy3): fix build with NDK r28c Aug 11, 2025
@robertkirkman robertkirkman marked this pull request as ready for review August 11, 2025 20:31
@robertkirkman
Copy link
Member Author

robertkirkman commented Aug 11, 2025 •
edited
Loading

Licy183, I believe I have added everything here that is necessary for pypy3, but which are limited and minimal enough changes not to be undesirable.

I do still believe that the Proot and QEMU executables need to be built from source, but I'm going to refrain from doing that here because I'm eventually going to propose the creation of a GitHub Actions Workflow in github.com/termux/termux-packages that runs in the GitHub ARM runner, and moving the ARM builds of pypy3 to there, which would optimize both the size of the build script and the length of time to build, simultaneously. It would also make the use of QEMU unnecessary.

I'm not ready for that yet, first I will wait for the termux-docker deblobbify PR to be merged and then after that I will start to make that.

@licy183 licy183 merged commit c41cf55 into termux:master Aug 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@licy183 licy183 licy183 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robertkirkman @licy183