-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
addpkg(main/hledger-ui): 1.43.2 #25403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
This didn't have to be a new PR, you can push changes to an existing PR via git push
, but since you changed it to a feature branch instead of using master
for the PR I suppose it may as well be a new PR.
Yeah it ended up being easier to just recreate the whole repo and redo the commit with the changes you mentioned 🤷 Thanks again for the feedback |
5f795bf
to
8cea741
Compare
If this is ready, would it be possible for you to edit the commit description to have this at the top?
|
Hey, thanks, I just did it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge this in 24 hours if no problems are found.
Strange, it seems like just the aarch64 build is taking an hour to run, then using up all of the GitHub Actions resources and terminating the run. |
It compiled successfully locally for me. It seems like there is a difference between local building (using |
Strange, I've tried running it in CI on my fork, and the "Packages" workflow worked fine and compiled the aarch64 package in 14 minutes https://github.com/a-zurcher/termux-packages/actions/runs/16452102638 |
I am not sure what is going on to cause this still, but when I tried in my own GitHub Actions account's CI, I might have reproduced it, https://github.com/robertkirkman/termux-packages/actions/runs/16466329579/job/46544538262 currently my aarch64 build there seems to be stuck at 30 minutes and still going. If it fails in the same way as here, then I can insert some logging into my branch and try to think of any way to find what is happening. |
Hello,
I followed the feedback from @TomJo2000 on #25402 and tried adding the hledger-ui package one more time