这是indexloc提供的服务,不要输入任何密码
Skip to content

addpkg(main/hledger-ui): 1.43.2 #25403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-zurcher
Copy link

Hello,

I followed the feedback from @TomJo2000 on #25402 and tried adding the hledger-ui package one more time

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

This didn't have to be a new PR, you can push changes to an existing PR via git push, but since you changed it to a feature branch instead of using master for the PR I suppose it may as well be a new PR.

@a-zurcher
Copy link
Author

Looks fine to me.

This didn't have to be a new PR, you can push changes to an existing PR via git push, but since you changed it to a feature branch instead of using master for the PR I suppose it may as well be a new PR.

Yeah it ended up being easier to just recreate the whole repo and redo the commit with the changes you mentioned 🤷

Thanks again for the feedback

@a-zurcher a-zurcher changed the title adding package hedger-ui (second try) adding package hledger-ui (second try) Jul 19, 2025
@a-zurcher a-zurcher changed the title adding package hledger-ui (second try) adding hledger-ui package (second try) Jul 19, 2025
@a-zurcher a-zurcher force-pushed the hledger-ui branch 3 times, most recently from 5f795bf to 8cea741 Compare July 19, 2025 09:09
@robertkirkman
Copy link
Contributor

If this is ready, would it be possible for you to edit the commit description to have this at the top?

addpkg(main/hledger-ui): 1.43.2

@a-zurcher
Copy link
Author

If this is ready, would it be possible for you to edit the commit description to have this at the top?

addpkg(main/hledger-ui): 1.43.2

Hey, thanks, I just did it

@a-zurcher a-zurcher changed the title adding hledger-ui package (second try) addpkg(main/hledger-ui): 1.43.2 Jul 22, 2025
Copy link
Contributor

@robertkirkman robertkirkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this in 24 hours if no problems are found.

@robertkirkman
Copy link
Contributor

Strange, it seems like just the aarch64 build is taking an hour to run, then using up all of the GitHub Actions resources and terminating the run.
I'll try building this locally to see what happens on a computer that doesn't kill processes.

@robertkirkman
Copy link
Contributor

robertkirkman commented Jul 22, 2025

It compiled successfully locally for me. It seems like there is a difference between local building (using scripts/run-docker.sh) and CI here. I can try to find what it is, after a while.

@a-zurcher
Copy link
Author

Strange, I've tried running it in CI on my fork, and the "Packages" workflow worked fine and compiled the aarch64 package in 14 minutes https://github.com/a-zurcher/termux-packages/actions/runs/16452102638

@robertkirkman
Copy link
Contributor

I am not sure what is going on to cause this still, but when I tried in my own GitHub Actions account's CI, I might have reproduced it,

https://github.com/robertkirkman/termux-packages/actions/runs/16466329579/job/46544538262

currently my aarch64 build there seems to be stuck at 30 minutes and still going.

If it fails in the same way as here, then I can insert some logging into my branch and try to think of any way to find what is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants