Adding hledger-ui package #25402
Adding hledger-ui package #25402
Conversation
There was a problem hiding this comment.
Hi thanks for the contribution, I have some feedback on a couple things that maybe aren't obvious for first time contributors.
On a procedural note, please make sure to update your PR branch via rebate instead of using merge commits.
I assume you are currently using something along the lines of git pull upstream master to do this.
Please make sure to use the pull rebate option to avoid creating unnecessary merge commits.
e.g. git -c pull.rebase pull upstream master.
It would have also been beneficial to make this PR on a branch other than master.
At the risk of dumping too many procedural notes on you at once, please also keep your commits squashed.
(This is a pre-written, saved reply.)
For adding to a single commit you can use git commit --amend.
Since you already have multiple commits on your branch though,
you'll need to squash those with git rebase -i HEAD~<n> first.
(Where <n> is the number of commits you want to modify.
Please make sure to only modify your commits.)
https://www.baeldung.com/ops/git-squash-commits#1-squash-the-last-x-commits
Since squashing or amending commits changes the git history you will need to force push any such changes.
e.g. git push --force,
or preferably git push --force-with-lease --force-if-includes
to make sure you aren't clobbering any refs you haven't fetched locally yet.
There was a problem hiding this comment.
This patch can be substituted for a symlink to the one in the hledger package since it is a direct copy.
Please make sure the symlink uses the relative path to the original patch.
Something similar is done for the patches for the emacs-x and vim-gtk packages as well if you are looking for an example.
| TERMUX_PKG_HOMEPAGE=https://hledger.org/ | ||
| TERMUX_PKG_DESCRIPTION="hledger-ui - terminal interface (TUI) for hledger, a robust, friendly plain text accounting app." | ||
| TERMUX_PKG_LICENSE="GPL-3.0-or-later" | ||
| TERMUX_PKG_MAINTAINER="@a-zurcher" |
There was a problem hiding this comment.
The maintainer field should follow the format used by Git for authorship.
e.g. Pseudonym Or Real Name <email@domain.example>.
This can also just be left as @termux.
Specifying a maintainer is intended to give us a point of contact for proposing structural changes to a package.
You are not required to list yourself as the maintainer for packages you submit.
There was a problem hiding this comment.
Thanks for the detailed feedback, I'll open a new pull request
Hello,
I've added the hledger-ui package, a package that manages hledger's files in a TUI interface.
After seeing the addition of the hledger package (see #25265) , I copied it's config and changed the TERMUX_PKG_SRCURL, TERMUX_PKG_SHA256, TERMUX_PKG_DESCRIPTION variables, and put myself as the maintainer.
I'm not sure if the dependencies should be modified, but the GitHub Action workflow successfully built the package on my fork, and it does run on my Pixel 6.