mark resolve issues inside a try block as warnings #4414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
✅ This changes can build |
🟢 CI successful 🟢Thanks |
|
Should it be a warning or should it just be accepted? |
28b451d to
c1d693e
Compare
sokra
reviewed
Apr 3, 2023
sokra
reviewed
Apr 3, 2023
| @@ -115,13 +115,15 @@ pub enum Effect { | |||
| /// The ast path to the condition. | |||
| ast_path: Vec<AstParentKind>, | |||
| span: Span, | |||
| in_try: bool, | |||
There was a problem hiding this comment.
I guess that doesn't need the flag, but nevermind...
There was a problem hiding this comment.
Unfortunately, it is actually used
sokra
approved these changes
Apr 3, 2023
| pkg = require("packages/found"); | ||
| } | ||
|
|
||
| pkg.fn(); |
There was a problem hiding this comment.
Probably need some snapshots and updates to the existing snapshots
sokra
reviewed
Apr 3, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 4, 2023
## Description
A require call inside a try block will only emit a warning instead of an error now.
I also added source information to the resolve issues where possible
### Example
```js
try {
require("missing-module");
} ...
```
previously this would show an error in the overlay, now it's just a warning
## Additional Turbopack Updates
* vercel/turborepo#4414 (requirement for this)
* vercel/turborepo#4434
* vercel/turborepo#4447
* vercel/turborepo#4448
* vercel/turborepo#4446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I also added source information to the resolve issues where possible
fix WEB-633