-
Notifications
You must be signed in to change notification settings - Fork 2.1k
use alias field for resolving module requests in packages #4434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 1 commit into
main
from
sokra/web-839-use-resolveinpackage-for-module-requests
Apr 3, 2023
Merged
use alias field for resolving module requests in packages #4434
kodiakhq
merged 1 commit into
main
from
sokra/web-839-use-resolveinpackage-for-module-requests
Apr 3, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
ForsakenHarmony
approved these changes
Apr 3, 2023
✅ This changes can build |
🟢 CI successful 🟢Thanks |
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 4, 2023
## Description A require call inside a try block will only emit a warning instead of an error now. I also added source information to the resolve issues where possible ### Example ```js try { require("missing-module"); } ... ``` previously this would show an error in the overlay, now it's just a warning ## Additional Turbopack Updates * vercel/turborepo#4414 (requirement for this) * vercel/turborepo#4434 * vercel/turborepo#4447 * vercel/turborepo#4448 * vercel/turborepo#4446
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 4, 2023
### What? tests for vercel/turborepo#4434
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…borepo#4434) ### Description e. g. `"browser": { "fs": false, "net": "./other.js" }` need to be handled ### Testing Instructions tests in next.js fix WEB-839
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…borepo#4434) ### Description e. g. `"browser": { "fs": false, "net": "./other.js" }` need to be handled ### Testing Instructions tests in next.js fix WEB-839
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…borepo#4434) ### Description e. g. `"browser": { "fs": false, "net": "./other.js" }` need to be handled ### Testing Instructions tests in next.js fix WEB-839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
e. g.
"browser": { "fs": false, "net": "./other.js" }
need to be handledTesting Instructions
tests in next.js
fix WEB-839