这是indexloc提供的服务,不要输入任何密码
Skip to content

use alias field for resolving module requests in packages #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 3, 2023

Description

e. g. "browser": { "fs": false, "net": "./other.js" } need to be handled

Testing Instructions

tests in next.js

fix WEB-839

@sokra sokra requested a review from a team as a code owner April 3, 2023 13:43
@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 1:43pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm
examples-cra-web ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm
examples-native-web ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 3, 2023 1:43pm

@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

✅ This changes can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

🟢 CI successful 🟢

Thanks

@kodiakhq kodiakhq bot merged commit a107879 into main Apr 3, 2023
@kodiakhq kodiakhq bot deleted the sokra/web-839-use-resolveinpackage-for-module-requests branch April 3, 2023 13:56
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Apr 4, 2023
## Description

A require call inside a try block will only emit a warning instead of an error now.

I also added source information to the resolve issues where possible

### Example
```js
try {
  require("missing-module");
} ...
```
previously this would show an error in the overlay, now it's just a warning

## Additional Turbopack Updates

* vercel/turborepo#4414 (requirement for this)
* vercel/turborepo#4434
* vercel/turborepo#4447
* vercel/turborepo#4448
* vercel/turborepo#4446
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Apr 4, 2023
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…borepo#4434)

### Description

e. g. `"browser": { "fs": false, "net": "./other.js" }` need to be
handled

### Testing Instructions

tests in next.js

fix WEB-839
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…borepo#4434)

### Description

e. g. `"browser": { "fs": false, "net": "./other.js" }` need to be
handled

### Testing Instructions

tests in next.js

fix WEB-839
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…borepo#4434)

### Description

e. g. `"browser": { "fs": false, "net": "./other.js" }` need to be
handled

### Testing Instructions

tests in next.js

fix WEB-839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants