这是indexloc提供的服务,不要输入任何密码
Skip to content

fix HMR for streaming responses #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023
Merged

fix HMR for streaming responses #4446

merged 2 commits into from
Apr 4, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 4, 2023

Description

this adds HMR support for streaming responses

fixes WEB-542

@sokra sokra requested a review from a team as a code owner April 4, 2023 08:39
@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-native-web 🔄 Building (Inspect) Apr 4, 2023 11:37am
examples-vite-web 🔄 Building (Inspect) Apr 4, 2023 11:37am
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 4, 2023 11:37am
examples-cra-web ⬜️ Ignored (Inspect) Apr 4, 2023 11:37am
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 4, 2023 11:37am
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 4, 2023 11:37am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 4, 2023 11:37am
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 4, 2023 11:37am
examples-svelte-web ⬜️ Ignored (Inspect) Apr 4, 2023 11:37am
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 4, 2023 11:37am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2023 11:37am

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

✅ This changes can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

🟢 CI successful 🟢

Thanks

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
@sokra sokra requested a review from alexkirsz April 4, 2023 11:39
@sokra sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Apr 4, 2023
@kodiakhq kodiakhq bot merged commit e6f3c7a into main Apr 4, 2023
@kodiakhq kodiakhq bot deleted the sokra/fix-rsc-hmr branch April 4, 2023 11:55
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Apr 4, 2023
## Description

A require call inside a try block will only emit a warning instead of an error now.

I also added source information to the resolve issues where possible

### Example
```js
try {
  require("missing-module");
} ...
```
previously this would show an error in the overlay, now it's just a warning

## Additional Turbopack Updates

* vercel/turborepo#4414 (requirement for this)
* vercel/turborepo#4434
* vercel/turborepo#4447
* vercel/turborepo#4448
* vercel/turborepo#4446
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

this adds HMR support for streaming responses

---------

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

this adds HMR support for streaming responses

---------

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

this adds HMR support for streaming responses

---------

Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants