-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Document persistent
key
#2669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document persistent
key
#2669
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion
@@ -130,7 +130,8 @@ You can also disable caching on specific tasks by setting the [`pipeline.<task>. | |||
"$schema": "https://turbo.build/schema.json", | |||
"pipeline": { | |||
"dev": { | |||
"cache": false | |||
"cache": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does persistent: true
automatically set cache
to false
?
If not, then it probably should?
And if it does, we should remove these cache: false
keys and document that you don't need to add them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not, at the moment. Might be a good consolidation down the road, but seems like an overreach when we introduce this. cache:false
also means ignoring outputs
, which has some baggage also.
🟢 CI successful 🟢Thanks |
@mehulkar Pushed a commit to this branch tidying up some language and removing |
bd3adca
to
4bb2605
Compare
- Adds to schema.json - Add docs to CLI reference
18be093
to
3060f0e
Compare
This adds documentation for the
persistent
key, adds it intodocumentation examples, and removes
--parallel
where it isn'tnecessary. It also updates
examples/
wheredev
tasks are used.turbo@1.7
is released to npm.Stacked PRs:
persistent
key #2669 (this one)Separate PR so we can merge docs in after the feature has been released.