这是indexloc提供的服务,不要输入任何密码
Skip to content

Document persistent key #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Nov 10, 2022

This adds documentation for the persistent key, adds it into
documentation examples, and removes --parallel where it isn't
necessary. It also updates examples/ where dev tasks are used.

⚠️ This PR should be merged after turbo@1.7 is released to npm.

Stacked PRs:

  1. Refactor TaskGraph construction #2546
  2. Ability to configure "persistent" tasks #2258
  3. Document persistent key #2669 (this one)
  4. Update examples with features from 1.7 release #2738

Separate PR so we can merge docs in after the feature has been released.

@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-cra-web 🔄 Building (Inspect) Visit Preview Jan 9, 2023 at 3:45PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 9, 2023 at 3:45PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:45PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:45PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:45PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:45PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:45PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:45PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:45PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:45PM (UTC)

Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

@tknickman tknickman added the pr: fixship A PR which is approved with notes and does not require re-review. label Nov 10, 2022
@@ -130,7 +130,8 @@ You can also disable caching on specific tasks by setting the [`pipeline.<task>.
"$schema": "https://turbo.build/schema.json",
"pipeline": {
"dev": {
"cache": false
"cache": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does persistent: true automatically set cache to false?

If not, then it probably should?

And if it does, we should remove these cache: false keys and document that you don't need to add them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not, at the moment. Might be a good consolidation down the road, but seems like an overreach when we introduce this. cache:false also means ignoring outputs, which has some baggage also.

@github-actions github-actions bot added the pkg: create-turbo Issues related to npx create-turbo label Nov 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

🟢 CI successful 🟢

Thanks

@mattpocock
Copy link
Contributor

@mehulkar Pushed a commit to this branch tidying up some language and removing cache: false where persistent: true was already present.

@mehulkar mehulkar force-pushed the mehulkar/turbo-530-docs-for-persistenttrue branch from bd3adca to 4bb2605 Compare November 16, 2022 22:04
@mehulkar mehulkar removed the area: examples Improvements or additions to examples label Nov 16, 2022
- Adds to schema.json
- Add docs to CLI reference
@tknickman tknickman force-pushed the mehulkar/turbo-530-docs-for-persistenttrue branch from 18be093 to 3060f0e Compare January 9, 2023 15:44
@tknickman tknickman merged commit 46e84fa into main Jan 10, 2023
@tknickman tknickman deleted the mehulkar/turbo-530-docs-for-persistenttrue branch January 10, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation docs: next release pkg: create-turbo Issues related to npx create-turbo pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo pr: fixship A PR which is approved with notes and does not require re-review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants