这是indexloc提供的服务,不要输入任何密码
Skip to content

Update docs on default outputs #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Nov 15, 2022

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 9, 2023 at 3:44PM (UTC)
turbo-vite-web 🔄 Building (Inspect) Visit Preview Jan 9, 2023 at 3:44PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:44PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:44PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:44PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:44PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:44PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:44PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:44PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2023 at 3:44PM (UTC)

@mehulkar mehulkar force-pushed the mehulkar/turbo-549-remove-default-outputs-behavior branch from a9ea366 to 6ea1478 Compare November 15, 2022 19:56
@mehulkar mehulkar changed the base branch from mehulkar/turbo-549-remove-default-outputs-behavior to mehulkar/turbo-550-codemod-for-default-outputs November 15, 2022 21:40
@mehulkar mehulkar force-pushed the mehulkar/turbo-550-codemod-for-default-outputs branch from d3da1bd to 8122a0f Compare November 15, 2022 21:40
@mehulkar mehulkar force-pushed the mehulkar/turbo-551-update-docs-about-default-outputs-array branch from c203db6 to b41851d Compare November 15, 2022 21:41
@mehulkar mehulkar force-pushed the mehulkar/turbo-550-codemod-for-default-outputs branch from 1ff7964 to b5b5110 Compare November 15, 2022 22:06
@mehulkar mehulkar force-pushed the mehulkar/turbo-551-update-docs-about-default-outputs-array branch from b41851d to 71fff2e Compare November 15, 2022 22:07
@mehulkar mehulkar marked this pull request as ready for review November 16, 2022 00:40
@mehulkar mehulkar requested a review from a team as a code owner November 16, 2022 00:40
@mehulkar mehulkar requested review from nathanhammond and NicholasLYang and removed request for a team November 16, 2022 00:40
@@ -80,11 +80,11 @@ export interface Pipeline {
* Note: turbo automatically logs stderr/stdout to .turbo/run-<task>.log. This file is
* always treated as a cacheable artifact and never needs to be specified.
*
* Passing an empty array can be used to tell turbo that a task is a side-effect and
* Omitting this key or passing an empty array can be used to tell turbo that a task is a side-effect and
Copy link
Contributor

@nathanhammond nathanhammond Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We provide no control over caching of logs. If you cache the task, we cache the logs. We cache by default. Therefore after this change, unless you specify cache: false in turbo.json or --no-cache at runtime this whole discussion is now weird. Given that there is no longer any reason to pass [] here (previously: prevent capturing the things in the default) we should probably reduce this explanation.

The set of glob patterns of a task's cacheable filesystem outputs.

Turborepo captures task logs for all tasks. This enables us to cache tasks whose runs produce no artifacts other than logs, such as linters. These logs are always treated as a cacheable artifact and never need to be specified.

/cc @mattpocock for wordsmith help?

@mehulkar mehulkar added the area: docs Improvements or additions to documentation label Nov 16, 2022
Base automatically changed from mehulkar/turbo-550-codemod-for-default-outputs to main November 16, 2022 21:28
@mehulkar mehulkar requested a review from a team as a code owner November 16, 2022 21:28
@mehulkar mehulkar force-pushed the mehulkar/turbo-551-update-docs-about-default-outputs-array branch from 71fff2e to 4087aa2 Compare November 16, 2022 21:29
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

🟢 CI successful 🟢

Thanks

Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a fantastic ergonomics win. 😅

@tknickman tknickman force-pushed the mehulkar/turbo-551-update-docs-about-default-outputs-array branch from 80ef364 to f2904e6 Compare January 9, 2023 15:43
@tknickman tknickman merged commit e2f7bd4 into main Jan 10, 2023
@tknickman tknickman deleted the mehulkar/turbo-551-update-docs-about-default-outputs-array branch January 10, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation area: examples Improvements or additions to examples docs: next release pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants