这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove parallel flag from all examples #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove parallel flag from all examples #2696

wants to merge 1 commit into from

Conversation

mattpocock
Copy link
Contributor

@mattpocock mattpocock commented Nov 14, 2022 •
edited
Loading

This will be overtaken by persistent: true in 1.7, so I've removed --parallel from all examples

Related: #2669

⚠️ This PR should be merged after turbo@1.7 is released to npm.

@mattpocock mattpocock requested a review from a team as a code owner November 14, 2022 10:56
@vercel
Copy link

vercel bot commented Nov 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 10:58AM (UTC)
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 10:58AM (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 10:58AM (UTC)
examples-svelte-web ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 10:58AM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 14, 2022 at 10:58AM (UTC)
2 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Nov 14, 2022 at 10:58AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Nov 14, 2022 at 10:58AM (UTC)

@github-actions github-actions bot added area: examples Improvements or additions to examples pkg: create-turbo Issues related to npx create-turbo labels Nov 14, 2022
@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

mehulkar
mehulkar reviewed Nov 14, 2022
View reviewed changes
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can you change the target branch to mehulkar/turbo-530-docs-for-persistenttrue so we can merge together?

@mehulkar mehulkar changed the base branch from main to mehulkar/turbo-530-docs-for-persistenttrue November 14, 2022 22:03
@mehulkar mehulkar requested a review from a team as a code owner November 14, 2022 22:03
@mehulkar mehulkar changed the base branch from mehulkar/turbo-530-docs-for-persistenttrue to main November 14, 2022 22:03
@mehulkar
Copy link
Contributor

Cherry picked into #2669

@mehulkar mehulkar closed this Nov 14, 2022
@mehulkar mehulkar deleted the matt/remove-persistent-flag-from-all-examples branch November 14, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar left review comments

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: examples Improvements or additions to examples pkg: create-turbo Issues related to npx create-turbo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattpocock @mehulkar