fix(watch): allow usage of turbo.jsonc #10340
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
left a comment
There was a problem hiding this comment.
This will avoid the error, but we need to implement the correct behavior so that turbo.jsonc triggers a package watcher event.
|
@chris-olszewski 🤦 When I hand-tested it, I was using a Just-in-Time package, so of course it looked like it worked. I added some code that for filewatching (I hope) and used a Compiled Package now and hand-tested again. It looks like it works (for real this time) - but I only tested a simple case. Do I look like I'm more on the right track now? I'm all but certain it's not all the way right, but I'll keep going if you say I'm headed the right direction. |
chris-olszewski
left a comment
There was a problem hiding this comment.
LGTM, only thing that really needs to get changed is the change to the exit handling in the package watcher
Description
Fixes #10323
Testing Instructions
I'm testing by hand as I'm aware its notoriously difficult to write tests in this area of the codebase.