-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(watch): allow usage of turbo.jsonc #10340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will avoid the error, but we need to implement the correct behavior so that turbo.jsonc
triggers a package watcher event.
@chris-olszewski 🤦 When I hand-tested it, I was using a Just-in-Time package, so of course it looked like it worked. I added some code that for filewatching (I hope) and used a Compiled Package now and hand-tested again. It looks like it works (for real this time) - but I only tested a simple case. Do I look like I'm more on the right track now? I'm all but certain it's not all the way right, but I'll keep going if you say I'm headed the right direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only thing that really needs to get changed is the change to the exit handling in the package watcher
Description
Fixes #10323
Testing Instructions
I'm testing by hand as I'm aware its notoriously difficult to write tests in this area of the codebase.