fix(watch): allow usage of turbo.jsonc #10340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
commented
Apr 14, 2025
chris-olszewski
requested changes
Apr 15, 2025
|
@chris-olszewski 🤦 When I hand-tested it, I was using a Just-in-Time package, so of course it looked like it worked. I added some code that for filewatching (I hope) and used a Compiled Package now and hand-tested again. It looks like it works (for real this time) - but I only tested a simple case. Do I look like I'm more on the right track now? I'm all but certain it's not all the way right, but I'll keep going if you say I'm headed the right direction. |
chris-olszewski
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10323
Testing Instructions
I'm testing by hand as I'm aware its notoriously difficult to write tests in this area of the codebase.