HKG: ccNC messages #1671
Merged
HKG: ccNC messages #1671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Jan 28, 2025
| SG_ LKA_ASSIST : 62|1@1+ (1,0) [0|1] "" XXX | ||
| SG_ LKA_MODE : 24|3@1+ (1,0) [0|7] "" XXX | ||
| SG_ NEW_SIGNAL_2 : 70|2@0+ (1,0) [0|3] "" XXX | ||
| SG_ NEW_SIGNAL_4 : 72|4@1+ (1,0) [0|15] "" XXX |
Contributor
There was a problem hiding this comment.
Can we give these semi-relevant, self-describing names?
Contributor
Author
There was a problem hiding this comment.
The added NEW_SIGNAL_4 & NEW_SIGNAL_5 are like the other NEW_SIGNAL_'s defined, just signals we set to match stock. Don't have anything other than that at the moment.
Contributor
There was a problem hiding this comment.
I know, but they should ideally be as descriptive as possible, or comments added in the DBC to hint at what we suspect they might do.
Past patterns aren't always correct!
Contributor
Author
There was a problem hiding this comment.
Added comments, values seem to always be the same, graph shows car on, off, then on again. We can remove if this isn't good enough.
sshane
reviewed
Jan 28, 2025
Closed
5 tasks
eli-davis
pushed a commit
to eli-davis/opendbc_reference
that referenced
this pull request
Jul 15, 2025
* Update hyundai_canfd.dbc * better names * add comments * fix DISTANCE factor * POSTION -> DISTANCE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New messages required by #1575 and used by newer hyundai cars