add plugin to comments #1341
add plugin to comments #1341
Conversation
6bfa33f to
7d5cb1d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1341 +/- ##
==========================================
- Coverage 91.65% 91.65% -0.01%
==========================================
Files 374 374
Lines 21050 21048 -2
==========================================
- Hits 19294 19292 -2
Misses 1756 1756 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d5cb1d to
291ee12
Compare
euwint
left a comment
There was a problem hiding this comment.
The changes definitely make sense.
Splitting up the show_analysis.html also provides a clearer overview.
However, I still have some change requests:
- Could the plugins in the comment dropdown also be sorted alphabetically?
- The information about the author of the comment is currently lost. I think it would be interesting to have information about the author and the creation time of the comment. Therefore, the information should also appear in the table
- Perhaps part of another pull request, but a comment function on the firmware comparison page also seems useful to me
- Also perhaps part of another pull request, but in the comment info on the start page, it might be useful to include information about the firmware for which the comment was left.
The information is actually still there: You can see it when you hover over the comment with your mouse |
4004174 to
5ee27d4
Compare
* also display the plugin and display author and time of comment as tooltip
|
Failed CI build is fixed in #1369 |
part of #1302