-
Notifications
You must be signed in to change notification settings - Fork 238
Open
Labels
Description
Feature description
The comment feature in FACT needs to be thoroughly upgraded to offer a real value in collaboration and note keeping. Some issues that should be addressed are:
- Aggregate comments on firmware level somehow
- Making sure no comments are lost
- Highlight on top of analysis page (tag?) if comments exist
- Attach related plugin to comment
- If navigated to comment, open plugin result (akin to pattern search, summary)
- Add comment should be modal
- Comments need not be collapsed
- Comment meta (user, timestamp) can be hidden and shown if wanted (hover, collapsible, ..)
Proposed plan of action:
- Identify additional features, code dependecies
- Adapt database scheme to fit analysis plugin
- First PR: Add analysis plugin relation to comments
- Second PR: Comment highlighting and aggregation
- Third PR: Modal, new look comment rendering