这是indexloc提供的服务,不要输入任何密码
Skip to content

FACT comments 2.0 #1302

@dorpvom

Description

@dorpvom

Feature description

The comment feature in FACT needs to be thoroughly upgraded to offer a real value in collaboration and note keeping. Some issues that should be addressed are:

  • Aggregate comments on firmware level somehow
    • Making sure no comments are lost
  • Highlight on top of analysis page (tag?) if comments exist
  • Attach related plugin to comment
    • If navigated to comment, open plugin result (akin to pattern search, summary)
  • Add comment should be modal
  • Comments need not be collapsed
  • Comment meta (user, timestamp) can be hidden and shown if wanted (hover, collapsible, ..)

Proposed plan of action:

  1. Identify additional features, code dependecies
  2. Adapt database scheme to fit analysis plugin
  3. First PR: Add analysis plugin relation to comments
  4. Second PR: Comment highlighting and aggregation
  5. Third PR: Modal, new look comment rendering

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions