-
Notifications
You must be signed in to change notification settings - Fork 2.8k
server: move Hasura.SQL to Hasura.Backends.Postgres #6053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4e4ce8 to
2dae2a6
Compare
Contributor
Author
|
This one is "urgent", kinda: it has to touch the imports of over 100 files, and is therefore a huge pain to rebase. ^^' |
49589c3 to
fed4ed2
Compare
fed4ed2 to
daa4513
Compare
0x777
approved these changes
Oct 27, 2020
Member
|
@nicuveo Some of the modules in |
Contributor
Author
|
Yeah I left them on purpose: they're technically not postgres-specific. Doesn't mean they have to stay there, of course. |
tirumaraiselvan
approved these changes
Oct 27, 2020
v0d1ch
pushed a commit
to v0d1ch/graphql-engine
that referenced
this pull request
Oct 29, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a trivial-but-verbose change: all Postgres-specific code in
Hasura.SQLis moved toHasura.Backends.Postgres. This paves the way towards having new backends, and clearly identifies all the parts of the code that currently rely on postgres-specific representation. This PR is verbose due to some auto-formatting happening on all the files that required an import change.