这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@nicuveo
Copy link
Contributor

@nicuveo nicuveo commented Oct 21, 2020

Description

This PR is a trivial-but-verbose change: all Postgres-specific code in Hasura.SQL is moved to Hasura.Backends.Postgres. This paves the way towards having new backends, and clearly identifies all the parts of the code that currently rely on postgres-specific representation. This PR is verbose due to some auto-formatting happening on all the files that required an import change.

@nicuveo
Copy link
Contributor Author

nicuveo commented Oct 22, 2020

This one is "urgent", kinda: it has to touch the imports of over 100 files, and is therefore a huge pain to rebase. ^^'

@nicuveo nicuveo requested review from lexi-lambda and removed request for 0x777 October 23, 2020 09:34
@nicuveo nicuveo changed the title Move all Postgres specific code to Hasura.Backends.Postgres server: move all Postgres specific code to Hasura.Backends.Postgres Oct 23, 2020
@nicuveo nicuveo requested a review from 0x777 October 25, 2020 06:52
@nicuveo nicuveo changed the title server: move all Postgres specific code to Hasura.Backends.Postgres server: move Hasura.SQL to Hasura.Backends.Postgres Oct 26, 2020
@0x777
Copy link
Member

0x777 commented Oct 27, 2020

@nicuveo Some of the modules in Hasura.SQL can be put elsewhere like Time.hs and GeoJSON.hs but that will be a task for another time.

@nicuveo
Copy link
Contributor Author

nicuveo commented Oct 27, 2020

Yeah I left them on purpose: they're technically not postgres-specific. Doesn't mean they have to stay there, of course.

@kodiakhq kodiakhq bot merged commit a8ed6a8 into hasura:master Oct 27, 2020
@nicuveo nicuveo deleted the sql-is-postgres branch October 27, 2020 14:15
v0d1ch pushed a commit to v0d1ch/graphql-engine that referenced this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants