这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@abooij
Copy link
Contributor

@abooij abooij commented Nov 4, 2020

Description

#6116 was based on a rebase of be84310a4c9f4757575c8f59241d602c1c78ce6c, which is part of PR #5797, which is based on b2561a7. However, since branching, the only file touched by #6116, namely server/src-lib/Hasura/GraphQL/Schema.hs, underwent a number of changes, and #6116 did not incorporate those of #5719 entirely. This PR attempts to fix that, in particular filtering tables and functions on having a valid GraphQL name.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No

Metadata

Does this PR add a new Metadata feature?

  • No

GraphQL

  • No new GraphQL schema is generated

Breaking changes

  • No Breaking changes

@abooij abooij changed the title re-implement table name validity filtering server: re-implement table name validity filtering Nov 4, 2020
Copy link
Contributor

@codingkarthik codingkarthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you 😄 . But on another note, is this the only piece of code that was lost in the rebase or were there other changes that might have been lost?

@abooij
Copy link
Contributor Author

abooij commented Nov 4, 2020

LGTM, Thank you 😄 . But on another note, is this the only piece of code that was lost in the rebase or were there other changes that might have been lost?

I have used the following git technique to figure this out. The commit that was rebased is be84310, so we want to figure out all changes on Schema.hs since the last common commit of be84310 until right before the merging of #6116, which got merged as fd8d51a. Using the commands: (note the triple periods in the commit range!)

$ git diff be84310...fd8d51a~ -- server/src-lib/Hasura/GraphQL/Schema.hs
# unfortunately we have to use a different syntax for git log, where ... means symmetric difference :-/
$ git log  $(git merge-base be84310 fd8d51a~)..fd8d51a~ -- server/src-lib/Hasura/GraphQL/Schema.hs

one obtains all the changes not included in be84310. The following commits are obtained:

The current version does not contain the phrases RemoteSchemaInfo or selectionSet. So from a functional point of view, after this PR is merged, Schema.hs contains all the above changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants