This repository was archived by the owner on Feb 16, 2023. It is now read-only.
Update default ports #691
Merged
Update default ports #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your PR. I am working on tutorial and I will clarify this |
Member
Author
|
@jmaunon cool, thanks! This PR can be merged together with tutorials then (or you can make it part of your tutorials update). |
cereallarceny
approved these changes
Aug 13, 2020
AmrMKayid
added a commit
that referenced
this pull request
Aug 14, 2020
* dev: [WIP] Update default ports (#691)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently according to README both PyGrid Node and Network use
5000as default port when started viarun.sh, however when started via docker-compose Node uses300xand Network uses5000. This leads to situation when model-centric tutorial/demos work or not depending on how PyGrid is started (w/ or w/o docker).(Additionally, it's not so clear from Network error what's wrong with model-centric API request)
We better assign consistent default ports to PyGrid Node and PyGrid Network so they do not collide.
Affected Dependencies
There're model-centric and grid tutorials in PySyft and demos in KotlinSyft, SwiftSyft, syft.js that use port 5000.
After model-centric API was moved to PyGrid Node, we didn't update ports to 3000 there.
If we put Node to 5xxx and Network to 7xxx, grid tutorials in PySyft needs update because they use 3xxx for Node and 5000 for Network.
But if we put Node on 3xxx and Network on 5000, model-centric tutorials/demos need update.
So both variants are breaking change either for model-centric or grid tutorials.
Please advice which is worse :)
p.s.
Another solution is to make Network to forward model-centric API to Nodes :)
How has this been tested?
Executed Node and Network via run.sh and docker-compose, checked ports.
Checklist