这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Conversation

@Benardi
Copy link
Contributor

@Benardi Benardi commented Aug 5, 2020

Description

Add Group model/table to Node DB.

Fixes #632

How has this been tested?

  • Unit test with creation of Group model

Checklist

@Benardi Benardi added the Type: Epic 🤙 Describes a large amount of functionality that will likely be broken down into smaller issues label Aug 5, 2020
@Benardi Benardi self-assigned this Aug 5, 2020
Copy link
Member

@cereallarceny cereallarceny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small change to make the tests more accurate to reality.

@@ -0,0 +1 @@
group_metrics = [("SysAdmins"), ("Data Analysts"), ("Hardware Owners")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for testing, but perhaps make up some university names instead to make it more accurate to reality. Groups are for grouping data scientists. You may have multiple researchers from the University of Oxford put in a group, for instance. But we won't be grouping people managing the node itself.

@Benardi Benardi requested a review from cereallarceny August 6, 2020 18:07
@cereallarceny cereallarceny merged commit 8d227d7 into dev Aug 7, 2020
@cereallarceny cereallarceny deleted the feature-632 branch August 7, 2020 18:43
AmrMKayid added a commit that referenced this pull request Aug 14, 2020
* dev:
  [WIP] Update default ports (#691)
  Improve websocket performance (#690)
  Create Group model in Node DB (#688)
  Fix dataset search (#687)
  Add support for FSS online key generation for data centric workers (#686)
  Create User model in Network DB (#683)
  Create Role model in Node DB (#684)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Epic 🤙 Describes a large amount of functionality that will likely be broken down into smaller issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Group model in Node DB

3 participants